fix(communities): fix saving communities is slow because of token fetch

Part of status-im/status-app#20954

I found that saving a big community, like the Status app, for the first time is very slow, averaging 35 seconds.
Turns out the reason is because of the community tokens. The community description handling called the token data fetching in the same thread and in a blocking way. Meaning that nothing was returned until the tokens were fetched. It also means that if the token fetching failed, the whole community saving and signaling would fail.

I moved the token handling in another thread, so that it doesn't slow the main operation. Then, once the fetching and saving is done, we signal again the new community data

(cherry picked from commit 2bee8b6)
(cherry picked from commit 17f1f2f)
(cherry picked from commit 758adcec55c3e4c5c2f4ac571d406a099ad50b26)

Author: jrainville

protocol/communities/manager.go

@@ -2172,10 +2172,6 @@ func (m *Manager) handleCommunityDescriptionMessageCommon(community *Community,
 		m.incrementCommunityImageVersion(community.IDString())
 	}
 
-	if err = m.handleCommunityTokensMetadata(community); err != nil {
-		return nil, err
-	}
-
 	hasCommunityArchiveInfo, err := m.persistence.HasCommunityArchiveInfo(community.ID())
 	if err != nil {
 		return nil, err
@@ -2261,6 +2257,10 @@ func (m *Manager) handleCommunityDescriptionMessageCommon(community *Community,
 		return nil, err
 	}
 
+	if len(community.CommunityTokensMetadata()) > 0 {
+		m.handleCommunityTokensMetadataAsync(community.IDString())
+	}
+
 	// We mark our requests as completed, though maybe we should mark
 	// any request for any user that has been added as completed
 	if err := m.markRequestToJoinAsAccepted(&m.identity.PublicKey, community); err != nil {
@@ -4471,6 +4471,31 @@ func (m *Manager) handleCommunityTokensMetadata(community *Community) error {
 	return nil
 }
 
+func (m *Manager) handleCommunityTokensMetadataAsync(communityID string) {
+	go func() {
+		defer utils.LogOnPanic()
+
+		select {
+		case <-m.quit:
+			return
+		default:
+		}
+
+		community, err := m.GetByIDString(communityID)
+		if err != nil {
+			return
+		}
+
+		err = m.handleCommunityTokensMetadata(community)
+		if err != nil {
+			return
+		}
+
+		m.publish(&Subscription{Community: community})
+
+	}()
+}
+
 func (m *Manager) HandleCommunityGrant(community *Community, grant []byte, clock uint64) (uint64, error) {
 	_, oldClock, err := m.GetCommunityGrant(community.IDString())
 	if err != nil {

protocol/communities_events_utils_test.go

@@ -1866,16 +1866,33 @@ func testAddAndSyncTokenFromControlNode(base CommunityEventsTestsInterface, comm
 	waitOnMessengerResponse(s, checkTokenAdded, base.GetMember())
 	waitOnMessengerResponse(s, checkTokenAdded, base.GetEventSender())
 
-	// check CommunityToken was added to the DB
-	syncTokens, err := base.GetEventSender().communitiesManager.GetAllCommunityTokens()
+	// Token metadata arrives via messenger response first; DB persistence can complete shortly after.
+	err = testutils.RetryWithBackOff(func() error {
+		syncTokens, err := base.GetEventSender().communitiesManager.GetAllCommunityTokens()
+		if err != nil {
+			return err
+		}
+		if len(syncTokens) != 1 {
+			return errors.New("event sender tokens should be 1")
+		}
+		if syncTokens[0].PrivilegesLevel != privilegesLvl {
+			return errors.New("event sender token privileges level does not match")
+		}
+		return nil
+	})
 	s.Require().NoError(err)
-	s.Require().Len(syncTokens, 1)
-	s.Require().Equal(syncTokens[0].PrivilegesLevel, privilegesLvl)
 
-	// check CommunityToken was added to the DB
-	syncTokens, err = base.GetMember().communitiesManager.GetAllCommunityTokens()
+	err = testutils.RetryWithBackOff(func() error {
+		syncTokens, err := base.GetMember().communitiesManager.GetAllCommunityTokens()
+		if err != nil {
+			return err
+		}
+		if len(syncTokens) != 1 {
+			return errors.New("member tokens should be 1")
+		}
+		return nil
+	})
 	s.Require().NoError(err)
-	s.Require().Len(syncTokens, 1)
 }
 
 func testAddAndSyncOwnerTokenFromControlNode(base CommunityEventsTestsInterface, community *communities.Community,