fix(login): put slow operations in go routines to speed up login (#7349)

* fix(login): put slow operations in go routines to speed up login

Needed for status-im/status-app#19856

During my investigation, I found that these two services take a long time to initiate and block the login process.
Putting these calls in go routines fixes the issue

* fix: started no in coroutine

---------

Co-authored-by: Anthony Laibe <491074+alaibe@users.noreply.github.com>

Author: jrainville

internal/timesource/ntp.go

@@ -213,10 +213,6 @@ func (s *ntpTimeSource) updateOffset() error {
 // runPeriodically runs periodically the given function based on ntpTimeSource
 // synchronization limits (fastNTPSyncPeriod / slowNTPSyncPeriod)
 func (s *ntpTimeSource) runPeriodically(ctx context.Context, fn func() error, starWithSlowSyncPeriod bool) {
-	if s.started {
-		return
-	}
-
 	period := s.fastNTPSyncPeriod
 	if starWithSlowSyncPeriod {
 		period = s.slowNTPSyncPeriod
@@ -289,25 +285,27 @@ func (s *ntpTimeSource) Start(ctx context.Context) error {
 	currentTime := s.now()
 	s.lastMonotonic = currentTime
 	ctx, cancel := context.WithCancel(ctx)
-
-	// Attempt to update the offset synchronously so that user can have reliable messages right away
-	err := s.updateOffset()
-	if err != nil {
-		// Failure to update can occur if the node is offline.
-		// Instead of returning an error, continue with the process as the update will be retried periodically.
-		logutils.ZapLogger().Error("failed to update offset", zap.Error(err))
-	}
-
-	s.runPeriodically(ctx, s.updateOffset, err == nil)
-
-	s.started = true
 	s.cancel = cancel
+	s.started = true
+
+	go func() {
+		defer common.LogOnPanic()
+		err := s.updateOffset()
+		if err != nil {
+			// Failure to update can occur if the node is offline.
+			// Instead of returning an error, continue with the process as the update will be retried periodically.
+			logutils.ZapLogger().Error("failed to update offset", zap.Error(err))
+		}
+		s.runPeriodically(ctx, s.updateOffset, err == nil)
+	}()
 
 	return nil
 }
 
 // Stop goroutine that updates time source.
 func (s *ntpTimeSource) Stop() {
+	s.stateMu.Lock()
+	defer s.stateMu.Unlock()
 	if s.cancel == nil {
 		return
 	}

internal/timesource/ntp_test.go

@@ -274,6 +274,8 @@ func TestGetCurrentTimeInMillis(t *testing.T) {
 	}
 
 	expectedTime := convertToMillis(currentTime.Add(responseOffset))
+	err := ts.updateOffset()
+	require.NoError(t, err)
 	n := ts.GetCurrentTimeInMillis()
 	require.Equal(t, expectedTime, n)
 	// test repeat invoke GetCurrentTimeInMillis

services/wallet/currency/service.go

@@ -44,16 +44,19 @@ func NewService(db *sql.DB, walletFeed *event.Feed, tokenManager *token.Manager,
 }
 
 func (s *Service) Start(ctx context.Context) {
-	// Update all fiat currency formats in cache
-	fiatFormats, err := s.getAllFiatCurrencyFormats()
-	if err == nil {
-		_ = s.db.UpdateCachedFormats(fiatFormats)
-	}
+	go func() {
+		defer gocommon.LogOnPanic()
+		// Update all fiat currency formats in cache
+		fiatFormats, err := s.getAllFiatCurrencyFormats()
+		if err == nil {
+			_ = s.db.UpdateCachedFormats(fiatFormats)
+		}
 
-	fixedTokenFormats, err := s.getAllFixedTokenCurrencyFormats()
-	if err == nil {
-		_ = s.db.UpdateCachedFormats(fixedTokenFormats)
-	}
+		fixedTokenFormats, err := s.getAllFixedTokenCurrencyFormats()
+		if err == nil {
+			_ = s.db.UpdateCachedFormats(fixedTokenFormats)
+		}
+	}()
 
 	go func() {
 		defer gocommon.LogOnPanic()