test(functional): address review on cross-version chat compat

- move peer-version resolution into the Makefile, selecting the latest
  patch per minor (two newest minors)
- add TODO above the temporary worktree-based peer-image build
- wrap banUserFromCommunity in the python wakuext service
- exercise add/remove members from both vut and peer sides with 2-3
  messages between each membership change; run the third node on the
  peer image so every exchange crosses versions

Author: Egor Rachkovskii

Makefile

@@ -544,6 +544,11 @@ test-functional-compatibility: export FUNCTIONAL_TESTS_DOCKER_UID ?= $(call sh,
 test-functional-compatibility: export FUNCTIONAL_TESTS_REPORT_CODECOV ?= false
 test-functional-compatibility: export USE_LOGOS_STORAGE := $(USE_LOGOS_STORAGE)
 test-functional-compatibility: export FUNCTIONAL_TESTS_MARKER := compatibility
+test-functional-compatibility: export PEER_REFS ?= $(if $(PEER_IMAGES),,$(shell git fetch --tags --quiet 2>/dev/null; \
+  git tag --sort=-v:refname 2>/dev/null \
+  | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$$' \
+  | awk -F. '!seen[$$1"."$$2]++' \
+  | head -2 | paste -sd' ' -))
 test-functional-compatibility: ##@tests Cross-version chat compatibility smoke tests (set PEER_IMAGES or PEER_REFS)
 	@./scripts/run_functional_tests.sh
 

scripts/run_functional_tests.sh

@@ -101,14 +101,11 @@ if [[ "${FUNCTIONAL_TESTS_MARKER}" == "compatibility" ]]; then
       resolved_peer_images+=("${img}")
     done
   else
-    if [[ -z "${PEER_REFS}" ]]; then
-      git fetch --tags --quiet || true
-      PEER_REFS="$(git tag --sort=-v:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -2 | tr '\n' ' ')"
-    fi
     if [[ -z "${PEER_REFS}" ]]; then
       echo -e "${RED}No peer refs available. Set PEER_REFS or PEER_IMAGES.${RST}"
       exit 1
     fi
+    # TODO: drop worktree build once released backend images are published to Harbor.
     for ref in ${PEER_REFS}; do
       ref_slug="$(printf '%s' "${ref}" | tr -c 'A-Za-z0-9_.-' '-' | sed 's/^[-.]*//; s/[-.]*$//')"
       peer_image="statusgo-peer-${ref_slug}"

tests-functional/clients/services/wakuext.py

@@ -445,6 +445,11 @@ def leave_community(self, community_id):
         response = self.rpc_request("leaveCommunity", params)
         return response
 
+    def ban_user_from_community(self, community_id: str, user: str, delete_all_messages: bool = False):
+        params = [{"communityId": community_id, "user": user, "deleteAllMessages": delete_all_messages}]
+        response = self.rpc_request("banUserFromCommunity", params)
+        return response
+
     def set_light_client(self, enabled=True):
         params = [{"enabled": enabled}]
         response = self.rpc_request("setLightClient", params)

tests-functional/steps/messenger.py

@@ -214,6 +214,45 @@ def private_group_message(message_count, private_group_id, sender=None, receiver
         )
 
 
+def add_group_member(admin, group_id, new_member, observers):
+    start = {observer.public_key: len(observer.received_signals[SignalType.MESSAGES_NEW]) for observer in observers}
+    response = admin.wakuext_service.add_members_to_group_chat(group_id, [new_member.public_key])
+    expected_message = get_message_by_content_type(
+        response,
+        content_type=MessageContentType.SYSTEM_MESSAGE_CONTENT_PRIVATE_GROUP.value,
+        message_pattern=f"@{admin.public_key} has added @{new_member.public_key}",
+    )[0]
+    for observer in observers:
+        with observer.expect_signal(SignalType.MESSAGES_NEW, pattern=expected_message.get("id"), timeout=60, start=start[observer.public_key]):
+            pass
+    return response
+
+
+def remove_group_member(admin, group_id, member, observers):
+    start = {observer.public_key: len(observer.received_signals[SignalType.MESSAGES_NEW]) for observer in observers}
+    response = admin.wakuext_service.remove_member_from_group_chat(group_id, member.public_key)
+    expected_message = get_message_by_content_type(
+        response,
+        content_type=MessageContentType.SYSTEM_MESSAGE_CONTENT_PRIVATE_GROUP.value,
+        message_pattern=f"@{member.public_key} left the group",
+    )[0]
+    for observer in observers:
+        with observer.expect_signal(SignalType.MESSAGES_NEW, pattern=expected_message.get("id"), timeout=60, start=start[observer.public_key]):
+            pass
+    return response
+
+
+def leave_group(node, group_id, observers=()):
+    start = {observer.public_key: len(observer.received_signals[SignalType.MESSAGES_NEW]) for observer in observers}
+    response = node.wakuext_service.leave_group_chat(group_id, True)
+    for observer in observers:
+        with observer.expect_signal(
+            SignalType.MESSAGES_NEW, pattern=f"@{node.public_key} left the group", timeout=60, start=start[observer.public_key]
+        ):
+            pass
+    return response
+
+
 # --- Community operations ---
 
 
@@ -696,6 +735,13 @@ def check_node_joined_community(node, joined, community_id):
     assert response.get("joined") is joined
 
 
+def ban_community_member(owner, community_id, member):
+    response = owner.wakuext_service.ban_user_from_community(community_id, member.public_key)
+    communities = [c for c in response.get("communities", []) if c.get("id") == community_id]
+    assert communities, f"banned community {community_id} not in response"
+    return response
+
+
 # --- One-to-one message operations ---
 
 

tests-functional/tests/test_chat_compatibility.py

@@ -23,17 +23,40 @@ def vut(self, backend_new_profile):
     def peer(self, backend_new_profile, peer_image):
         return backend_new_profile("peer", image=peer_image)
 
+    @pytest.fixture()
+    def third(self, backend_new_profile, peer_image):
+        return backend_new_profile("third", image=peer_image)
+
     def test_one_to_one_compatibility(self, vut, peer):
         messenger.make_contacts(vut, peer)
         messenger.one_to_one_message(1, sender=vut, receiver=peer)
         messenger.one_to_one_message(1, sender=peer, receiver=vut)
 
-    def test_group_chat_compatibility(self, vut, peer):
+    def test_group_chat_compatibility(self, vut, peer, third):
         messenger.make_contacts(vut, peer)
+        messenger.make_contacts(vut, third)
+
         group_id = messenger.join_private_group(admin=vut, member=peer)
-        messenger.private_group_message(1, group_id, sender=vut, receiver=peer)
+        messenger.private_group_message(2, group_id, sender=vut, receiver=peer)
+
+        messenger.add_group_member(vut, group_id, third, observers=[peer, third])
+        messenger.private_group_message(2, group_id, sender=vut, receiver=third)
+
+        messenger.remove_group_member(vut, group_id, third, observers=[peer])
+        messenger.private_group_message(2, group_id, sender=peer, receiver=vut)
 
-    def test_community_compatibility(self, vut, peer):
+        messenger.leave_group(peer, group_id, observers=[vut])
+
+    def test_community_compatibility(self, vut, peer, third):
         community_id = messenger.create_community(vut)
+
         chat_id = messenger.join_community(member=peer, admin=vut, community_id=community_id)
-        messenger.community_messages(chat_id, 1, sender=vut, receiver=peer)
+        messenger.community_messages(chat_id, 2, sender=vut, receiver=peer)
+
+        messenger.join_community(member=third, admin=vut, community_id=community_id)
+        messenger.community_messages(chat_id, 2, sender=vut, receiver=third)
+
+        messenger.ban_community_member(vut, community_id, third)
+        messenger.community_messages(chat_id, 2, sender=peer, receiver=vut)
+
+        messenger.leave_the_community(peer, community_id)