fix(storenode): restore 30-page community fetch cap — 3 pages starved busy-topic descriptions (#21470-hf)

On-device (S21FE, dev fleet): with the 3-page cap the Status community's
1.4MB description became unreachable — its universal topic carries all
channels' traffic, so the newest 3 pages (~150 envelopes) never contained
the periodically-republished description. 62 capped fetch attempts, 23
backoff suppressions, zero resolves, community permanently absent from
Discover; low-traffic communities resolved fine. 30 pages reached it in
every measured run. Deep pages are now affordable: the keyless early-drop
gate (36dd3cf) discards undecryptable envelopes cheaply, empty pages
skip processing (cae6698), and the description-seen gate (6cd6ced)
still ends the request on the first hit. The tighter-than-contact test
assertion is relaxed to not-looser-than accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 2e1dc62)
(cherry picked from commit fbab6816d95f1c397aadafcac8cab7e33507eb2c)

Author: alexjba

protocol/messenger_store_node_request_manager_config.go

@@ -9,18 +9,18 @@ package protocol
 // full 31-day store-node window and burns CPU/battery on the device.
 const maxStoreNodeRequestPageCount = 30
 
-// maxCommunityStoreNodeRequestPageCount caps community fetches far more tightly
-// than the generic contact cap (issue #21470-hf). Store queries page newest-first
-// (verified in go-waku history.go: PaginationForward unset => proto3 default false
-// => backward) and community descriptions are republished periodically, so a live
-// community's description lands within the first pages; the description-seen gate
-// (6cd6ced1a) then stops the request on that hit. Deeper paging can therefore only
-// ever chew empty/irrelevant history — exactly the device failure mode: dead
-// curated ids each cost a ~minutes-long 30-page run finalizing with
-// fetchedEnvelopesCount=0. 3 pages keeps a healthy fetch (1-2 pages) untouched
-// while collapsing a dead-id run to a fraction of its former cost. Applied only at
-// the community construction site; the contact/default cap stays at 30.
-const maxCommunityStoreNodeRequestPageCount = 3
+// maxCommunityStoreNodeRequestPageCount caps community fetches (issue #21470-hf).
+// Store queries page newest-first, but on a HIGH-TRAFFIC community the universal
+// content topic carries all channels' messages, so the periodically-republished
+// description can sit well below the newest pages: on-device (Samsung S21FE, dev
+// fleet) a 3-page cap made the Status community's 1.4MB description UNREACHABLE —
+// 62 capped fetch attempts, zero resolves, community permanently absent from
+// Discover — while low-traffic communities resolved in 1-2 pages. 30 pages
+// (~1500 envelopes) reliably reached it in every measured run. Deep pages are
+// affordable now that undecryptable envelopes drop early (keyless gate,
+// 36dd3cf7f) and empty pages skip processing; the description-seen gate
+// (6cd6ced1a) still stops a request the moment the description appears.
+const maxCommunityStoreNodeRequestPageCount = 30
 
 type StoreNodeRequestConfig struct {
 	WaitForResponse   bool

protocol/messenger_store_node_request_manager_config_test.go

@@ -75,8 +75,8 @@ func TestStoreNodeRequestPageCap(t *testing.T) {
 // fetches keep the generous 30-page cap; only the community construction site is
 // tightened, never the shared default.
 func TestCommunityStoreNodeRequestPageCap(t *testing.T) {
-	t.Run("community construction caps at 3 pages", func(t *testing.T) {
-		require.Equal(t, 3, maxCommunityStoreNodeRequestPageCount)
+	t.Run("community construction caps at 30 pages", func(t *testing.T) {
+		require.Equal(t, 30, maxCommunityStoreNodeRequestPageCount)
 		cfg := buildCommunityStoreNodeRequestConfig(nil)
 		require.Equal(t, maxCommunityStoreNodeRequestPageCount, cfg.MaxPageCount)
 	})
@@ -87,10 +87,10 @@ func TestCommunityStoreNodeRequestPageCap(t *testing.T) {
 		require.Equal(t, maxStoreNodeRequestPageCount, cfg.MaxPageCount)
 	})
 
-	t.Run("community construction is tighter than contact construction", func(t *testing.T) {
+	t.Run("community construction is not looser than contact construction", func(t *testing.T) {
 		community := buildCommunityStoreNodeRequestConfig(nil)
 		contact := buildStoreNodeRequestConfig(nil)
-		require.Less(t, community.MaxPageCount, contact.MaxPageCount)
+		require.LessOrEqual(t, community.MaxPageCount, contact.MaxPageCount)
 	})
 
 	t.Run("community construction inherits the shared non-cap defaults", func(t *testing.T) {