test: parametrize functional tests for waku light client mode

Add waku_light_client parametrization to 6 functional test files so each
test runs in both full node and light client mode. Doubles test count
from 57 to 114.

Files parametrized:
- test_wakuext_group_chats.py
- test_wakuext_contact_verification.py
- test_one_to_one_messages.py
- test_contact_request.py
- test_private_groups_messages.py
- test_create_private_groups.py

Author: glitchminer

tests-functional/resources/constants.py

@@ -143,6 +143,10 @@ class Account:
 
 NATIVE_TOKEN_ADDRESS = "0x0000000000000000000000000000000000000000"
 
+# Waku light client test IDs
+FULL_NODE = "wakuV2LightClient_False"
+LIGHT_CLIENT = "wakuV2LightClient_True"
+
 # Well-known burn address, used as a generic recipient in tests
 BURN_ADDRESS = "0x000000000000000000000000000000000000dEaD"
 

tests-functional/tests/reliability/test_contact_request.py

@@ -5,18 +5,19 @@
 from steps import messenger
 from clients.signals import SignalType
 from resources.enums import MessageContentType
-from resources.constants import USE_IPV6
+from resources.constants import USE_IPV6, FULL_NODE, LIGHT_CLIENT
 
 
 @pytest.mark.reliability
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestContactRequests:
     @pytest.fixture()
-    def sender(self, backend_new_profile):
-        return backend_new_profile("sender", bridge_network=True)
+    def sender(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("sender", waku_light_client=waku_light_client, bridge_network=True)
 
     @pytest.fixture()
-    def receiver(self, backend_new_profile):
-        return backend_new_profile("receiver", bridge_network=True)
+    def receiver(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("receiver", waku_light_client=waku_light_client, bridge_network=True)
 
     def _run_contact_request_baseline(self, sender, receiver, execution_number=None, network_condition=None):
         messenger.add_contact(

tests-functional/tests/reliability/test_create_private_groups.py

@@ -3,19 +3,20 @@
 import pytest
 from steps import messenger
 from clients.signals import SignalType
-from resources.constants import USE_IPV6
+from resources.constants import USE_IPV6, FULL_NODE, LIGHT_CLIENT
 
 
 @pytest.mark.reliability
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestCreatePrivateGroups:
 
     @pytest.fixture()
-    def community_admin(self, backend_new_profile):
-        return backend_new_profile("community_admin", bridge_network=True)
+    def community_admin(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("community_admin", waku_light_client=waku_light_client, bridge_network=True)
 
     @pytest.fixture()
-    def community_member(self, backend_new_profile):
-        return backend_new_profile("member", bridge_network=True)
+    def community_member(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("member", waku_light_client=waku_light_client, bridge_network=True)
 
     def _run_create_private_group_baseline(self, community_admin, community_member, private_groups_count=1):
         messenger.make_contacts(community_admin, community_member)

tests-functional/tests/reliability/test_one_to_one_messages.py

@@ -3,19 +3,20 @@
 import pytest
 from steps import messenger
 from clients.signals import SignalType
-from resources.constants import USE_IPV6
+from resources.constants import USE_IPV6, FULL_NODE, LIGHT_CLIENT
 
 
 @pytest.mark.reliability
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestOneToOneMessages:
 
     @pytest.fixture()
-    def sender(self, backend_new_profile):
-        return backend_new_profile("sender", bridge_network=True)
+    def sender(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("sender", waku_light_client=waku_light_client, bridge_network=True)
 
     @pytest.fixture()
-    def receiver(self, backend_new_profile):
-        return backend_new_profile("receiver", bridge_network=True)
+    def receiver(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("receiver", waku_light_client=waku_light_client, bridge_network=True)
 
     def _run_one_to_one_message_baseline(self, sender, receiver, message_count=1):
         messenger.one_to_one_message(message_count, sender=sender, receiver=receiver)

tests-functional/tests/reliability/test_private_groups_messages.py

@@ -3,19 +3,20 @@
 import pytest
 from steps import messenger
 from clients.signals import SignalType
-from resources.constants import USE_IPV6
+from resources.constants import USE_IPV6, FULL_NODE, LIGHT_CLIENT
 
 
 @pytest.mark.reliability
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestPrivateGroupMessages:
 
     @pytest.fixture()
-    def community_admin(self, backend_new_profile):
-        return backend_new_profile("community_admin", bridge_network=True)
+    def community_admin(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("community_admin", waku_light_client=waku_light_client, bridge_network=True)
 
     @pytest.fixture()
-    def community_member(self, backend_new_profile):
-        return backend_new_profile("community_member", bridge_network=True)
+    def community_member(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("community_member", waku_light_client=waku_light_client, bridge_network=True)
 
     def _run_private_group_messages_baseline(self, community_admin, community_member, message_count=1):
         messenger.make_contacts(community_admin, community_member)

tests-functional/tests/test_wakuext_contact_verification.py

@@ -3,21 +3,23 @@
 import pytest
 
 from clients.signals import SignalType
+from resources.constants import FULL_NODE, LIGHT_CLIENT
 from resources.enums import ContactVerificationState, MessageContentType
 from steps import async_messenger
 
 
 @pytest.mark.rpc
 @pytest.mark.asyncio
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestContactVerification:
 
     @pytest.fixture
-    async def creator(self, async_backend_new_profile):
-        return await async_backend_new_profile("creator")
+    async def creator(self, async_backend_new_profile, waku_light_client):
+        return await async_backend_new_profile("creator", waku_light_client=waku_light_client)
 
     @pytest.fixture
-    async def member(self, async_backend_new_profile, creator):
-        m = await async_backend_new_profile("member")
+    async def member(self, async_backend_new_profile, waku_light_client, creator):
+        m = await async_backend_new_profile("member", waku_light_client=waku_light_client)
         await async_messenger.make_contacts(sender=creator, receiver=m)
         return m
 

tests-functional/tests/test_wakuext_group_chats.py

@@ -1,19 +1,21 @@
 from uuid import uuid4
 import pytest
 from steps import messenger
+from resources.constants import FULL_NODE, LIGHT_CLIENT
 from resources.enums import MessageContentType
 
 
 @pytest.mark.rpc
+@pytest.mark.parametrize("waku_light_client", [False, True], indirect=True, ids=[FULL_NODE, LIGHT_CLIENT])
 class TestCreatePrivateGroups:
 
     @pytest.fixture()
-    def community_admin(self, backend_new_profile):
-        return backend_new_profile("community_admin")
+    def community_admin(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("community_admin", waku_light_client=waku_light_client)
 
     @pytest.fixture()
-    def community_member(self, backend_new_profile):
-        return backend_new_profile("community_member")
+    def community_member(self, backend_new_profile, waku_light_client):
+        return backend_new_profile("community_member", waku_light_client=waku_light_client)
 
     def test_create_group_chat_with_members(self, community_admin, community_member):
         messenger.make_contacts(community_admin, community_member)
@@ -60,8 +62,8 @@ def test_leave_group_chat(self, community_admin, community_member):
         assert len(members_after_leave) == 1
         assert community_admin.public_key not in str(members_after_leave)
 
-    def test_send_group_chat_invitation_request(self, community_admin, community_member, backend_new_profile):
-        third_node = backend_new_profile("third_node")
+    def test_send_group_chat_invitation_request(self, community_admin, community_member, backend_new_profile, waku_light_client):
+        third_node = backend_new_profile("third_node", waku_light_client=waku_light_client)
         messenger.make_contacts(community_admin, third_node)
 
         messenger.make_contacts(community_admin, community_member)
@@ -103,8 +105,8 @@ def test_create_group_chat_from_invitation(self, community_admin, community_memb
         assert chats[0].get("invitationAdmin", "") == community_admin.public_key
         assert chats[0].get("name", "") == invitation_group
 
-    def test_add_members_to_group_chat(self, community_admin, community_member, backend_new_profile):
-        third_node = backend_new_profile("third_node")
+    def test_add_members_to_group_chat(self, community_admin, community_member, backend_new_profile, waku_light_client):
+        third_node = backend_new_profile("third_node", waku_light_client=waku_light_client)
         messenger.make_contacts(community_admin, third_node)
 
         messenger.make_contacts(community_admin, community_member)
@@ -146,8 +148,8 @@ def test_remove_member_from_group_chat(self, community_admin, community_member):
             message_pattern=f"@{community_member.public_key} left the group",
         )[0]
 
-    def test_remove_members_from_group_chat(self, community_admin, community_member, backend_new_profile):
-        third_node = backend_new_profile("third_node")
+    def test_remove_members_from_group_chat(self, community_admin, community_member, backend_new_profile, waku_light_client):
+        third_node = backend_new_profile("third_node", waku_light_client=waku_light_client)
         messenger.make_contacts(community_admin, third_node)
 
         messenger.make_contacts(community_admin, community_member)
@@ -211,8 +213,8 @@ def test_change_group_chat_name(self, community_admin, community_member):
         assert chats[0].get("name", "") == new_group_name
 
     @pytest.mark.skip(reason="waiting for https://github.com/status-im/status-go/issues/6752 resolution")
-    def test_get_group_chat_invitations(self, community_admin, community_member, backend_new_profile):
-        third_node = backend_new_profile("third_node")
+    def test_get_group_chat_invitations(self, community_admin, community_member, backend_new_profile, waku_light_client):
+        third_node = backend_new_profile("third_node", waku_light_client=waku_light_client)
         messenger.make_contacts(community_admin, third_node)
 
         messenger.make_contacts(community_admin, community_member)
@@ -230,8 +232,8 @@ def test_get_group_chat_invitations(self, community_admin, community_member, bac
         third_node.wakuext_service.get_group_chat_invitations()
         # TODO: Add more assertions on response
 
-    def test_send_group_chat_invitation_rejection(self, community_admin, community_member, backend_new_profile):
-        third_node = backend_new_profile("third_node")
+    def test_send_group_chat_invitation_rejection(self, community_admin, community_member, backend_new_profile, waku_light_client):
+        third_node = backend_new_profile("third_node", waku_light_client=waku_light_client)
         messenger.make_contacts(community_admin, third_node)
 
         messenger.make_contacts(community_admin, community_member)