Do I like the run_unit_tests.sh, which was overcomplicated before this PR and should have not even existed from the beginning, now +40 lines? Absolutely not.
Go runs tests in parallel out of the box. The reason why we had to build this over-engineered wrapper-script around is simple: protocol package is overloaded and some of the single tests take too much time.
I would rather invest time in:
- splitting protocol package into smaller parts
- extract
/tests/integration package, to distinct unit and integration tests
- find long-running unextractable tests and mark them with
t.Parallel()
Originally posted by @igor-sirotin in #7549 (review)
Do I like the
run_unit_tests.sh, which was overcomplicated before this PR and should have not even existed from the beginning, now +40 lines? Absolutely not.Go runs tests in parallel out of the box. The reason why we had to build this over-engineered wrapper-script around is simple:
protocolpackage is overloaded and some of the single tests take too much time.I would rather invest time in:
/tests/integrationpackage, to distinct unit and integration testst.Parallel()Originally posted by @igor-sirotin in #7549 (review)