Not reachable from the Status client.
The client does not take this password from the user. It derives it from the mnemonic (keycard_convert_account.nim:34-36), and a wrong mnemonic fails at login first. Filing this as an API-boundary observation, not a user-facing bug.
What happens:
ConvertToRegularAccount does not verify currPassword before it changes state.
ensureDBsOpened (pkg/backend/geth_backend.go:1626) passes the password down but never uses it while a session is open — ensureAppDBOpened (:532) and ensureWalletDBOpened (:592) both return early when the handle is already set.
The function then clears KeycardPairing (:1636) and recreates the keystore files (:1641), encrypting them with the unverified password. Only the final ChangeDatabasePassword fails.
The result is a mixed state: pairing cleared, keystore files that open only with the wrong password, database password still the keycard one, app DB closed by the failure.
Steps to reproduce (Go test calling the backend directly: not a client flow)
- Convert a profile to keycard (
ConvertToKeycardAccount, normal flow).
- Stay logged in.
- Call
ConvertToRegularAccount with the correct mnemonic and a wrong currPassword.
Observed (develop bd4201f95):
error failed to set journal_mode pragma: file is not a database from the last step only. Afterwards: KeycardPairing is ""; 3 keystore files exist and open only with the wrong password; VerifyDatabasePassword succeeds only with the keycard password; appDB is nil.
Suggested: verify the password before any state change.
Close this if the team's position is that callers own validation
Not reachable from the Status client.
The client does not take this password from the user. It derives it from the mnemonic (
keycard_convert_account.nim:34-36), and a wrong mnemonic fails at login first. Filing this as an API-boundary observation, not a user-facing bug.What happens:
ConvertToRegularAccountdoes not verifycurrPasswordbefore it changes state.ensureDBsOpened(pkg/backend/geth_backend.go:1626) passes the password down but never uses it while a session is open —ensureAppDBOpened(:532) andensureWalletDBOpened(:592) both return early when the handle is already set.The function then clears
KeycardPairing(:1636) and recreates the keystore files (:1641), encrypting them with the unverified password. Only the finalChangeDatabasePasswordfails.The result is a mixed state: pairing cleared, keystore files that open only with the wrong password, database password still the keycard one, app DB closed by the failure.
Steps to reproduce (Go test calling the backend directly: not a client flow)
ConvertToKeycardAccount, normal flow).ConvertToRegularAccountwith the correct mnemonic and a wrongcurrPassword.Observed (develop
bd4201f95):error
failed to set journal_mode pragma: file is not a databasefrom the last step only. Afterwards:KeycardPairingis""; 3 keystore files exist and open only with the wrong password;VerifyDatabasePasswordsucceeds only with the keycard password; appDB is nil.Suggested: verify the password before any state change.
Close this if the team's position is that callers own validation