-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathadSegmentMerge.test.ts
More file actions
355 lines (288 loc) · 11.2 KB
/
Copy pathadSegmentMerge.test.ts
File metadata and controls
355 lines (288 loc) · 11.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
/**
* Unit Tests for Ad Segment Merge Logic
*
* Tests cover all required POC scenarios:
* 1. Ad inside a chapter (skip occurs, chapter unchanged)
* 2. Two overlapping ads merged/deduped
* 3. Ad touching chapter boundary exactly
* 4. Invalid ad dropped
* 5. Scrub backwards into ad → skip again (tested in playerAdSkip.test.ts)
*/
import {
validateAdSegment,
filterValidAdSegments,
mergeAdSegments,
findAdSegmentAtTime,
adSegmentsOverlap,
} from '~/services/adSegments/adSegmentMerge'
import { AdSegment, AdSegmentValidationError } from '~/services/adSegments/adSegmentTypes'
describe('Ad Segment Validation', () => {
test('valid ad segment passes validation', () => {
const segment: AdSegment = {
id: 'ad-001',
startTime: 10,
endTime: 40,
taggerPubkey: 'npub1test',
}
const result = validateAdSegment(segment)
expect(result.valid).toBe(true)
expect(result.errors).toHaveLength(0)
})
test('invalid ad: missing endTime', () => {
const segment: any = {
id: 'ad-002',
startTime: 10,
taggerPubkey: 'npub1test',
// endTime missing
}
const result = validateAdSegment(segment)
expect(result.valid).toBe(false)
expect(result.errors).toContain(AdSegmentValidationError.MISSING_END_TIME)
})
test('invalid ad: endTime <= startTime', () => {
const segment: AdSegment = {
id: 'ad-003',
startTime: 100,
endTime: 100, // Equal to startTime
taggerPubkey: 'npub1test',
}
const result = validateAdSegment(segment)
expect(result.valid).toBe(false)
expect(result.errors).toContain(AdSegmentValidationError.INVALID_TIME_RANGE)
})
test('invalid ad: negative times', () => {
const segment: AdSegment = {
id: 'ad-004',
startTime: -10,
endTime: 20,
taggerPubkey: 'npub1test',
}
const result = validateAdSegment(segment)
expect(result.valid).toBe(false)
expect(result.errors).toContain(AdSegmentValidationError.NEGATIVE_TIME)
})
test('invalid ad: missing tagger', () => {
const segment: AdSegment = {
id: 'ad-005',
startTime: 10,
endTime: 20,
taggerPubkey: '',
}
const result = validateAdSegment(segment)
expect(result.valid).toBe(false)
expect(result.errors).toContain(AdSegmentValidationError.MISSING_TAGGER)
})
})
describe('Filter Valid Ad Segments', () => {
test('filters out invalid segments', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 40, taggerPubkey: 'npub1test' }, // Valid
{ id: 'ad-002', startTime: 50, endTime: 50, taggerPubkey: 'npub1test' }, // Invalid (endTime == startTime)
{ id: 'ad-003', startTime: 60, endTime: 90, taggerPubkey: 'npub1test' }, // Valid
{ id: 'ad-004', startTime: 100, endTime: 80, taggerPubkey: 'npub1test' }, // Invalid (endTime < startTime)
]
const valid = filterValidAdSegments(segments, false)
expect(valid).toHaveLength(2)
expect(valid[0].id).toBe('ad-001')
expect(valid[1].id).toBe('ad-003')
})
})
describe('Merge Overlapping Ad Segments', () => {
test('merges two overlapping ads', () => {
const segments: AdSegment[] = [
{
id: 'ad-001',
startTime: 10,
endTime: 30,
taggerPubkey: 'npub1tagger1',
},
{
id: 'ad-002',
startTime: 25,
endTime: 50,
taggerPubkey: 'npub1tagger2',
},
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(1)
expect(merged[0].startTime).toBe(10)
expect(merged[0].endTime).toBe(50)
expect(merged[0].sourceSegmentIds).toEqual(['ad-001', 'ad-002'])
expect(merged[0].allTaggerPubkeys).toEqual(['npub1tagger1', 'npub1tagger2'])
})
test('merges adjacent ads (touching boundaries)', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' },
{ id: 'ad-002', startTime: 30, endTime: 50, taggerPubkey: 'npub1test' }, // Starts exactly where ad-001 ends
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(1)
expect(merged[0].startTime).toBe(10)
expect(merged[0].endTime).toBe(50)
})
test('does not merge non-overlapping ads', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' },
{ id: 'ad-002', startTime: 50, endTime: 70, taggerPubkey: 'npub1test' },
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(2)
expect(merged[0].startTime).toBe(10)
expect(merged[0].endTime).toBe(30)
expect(merged[1].startTime).toBe(50)
expect(merged[1].endTime).toBe(70)
})
test('merges multiple overlapping ads into one', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test1' },
{ id: 'ad-002', startTime: 20, endTime: 40, taggerPubkey: 'npub1test2' },
{ id: 'ad-003', startTime: 35, endTime: 60, taggerPubkey: 'npub1test3' },
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(1)
expect(merged[0].startTime).toBe(10)
expect(merged[0].endTime).toBe(60)
expect(merged[0].sourceSegmentIds).toEqual(['ad-001', 'ad-002', 'ad-003'])
expect(merged[0].allTaggerPubkeys).toHaveLength(3)
})
test('handles empty input', () => {
const merged = mergeAdSegments([])
expect(merged).toHaveLength(0)
})
test('handles single ad segment', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' },
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(1)
expect(merged[0].startTime).toBe(10)
expect(merged[0].endTime).toBe(30)
})
test('filters invalid ads before merging', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' }, // Valid
{ id: 'ad-002', startTime: 40, endTime: 40, taggerPubkey: 'npub1test' }, // Invalid
{ id: 'ad-003', startTime: 50, endTime: 70, taggerPubkey: 'npub1test' }, // Valid
]
const merged = mergeAdSegments(segments)
// Should only merge the 2 valid segments
expect(merged).toHaveLength(2)
})
})
describe('Find Ad Segment at Time', () => {
const mergedSegments = [
{ startTime: 10, endTime: 30, sourceSegmentIds: ['ad-001'], primaryTaggerPubkey: 'npub1test', allTaggerPubkeys: ['npub1test'] },
{ startTime: 50, endTime: 70, sourceSegmentIds: ['ad-002'], primaryTaggerPubkey: 'npub1test', allTaggerPubkeys: ['npub1test'] },
{ startTime: 100, endTime: 120, sourceSegmentIds: ['ad-003'], primaryTaggerPubkey: 'npub1test', allTaggerPubkeys: ['npub1test'] },
]
test('finds ad segment at time within range', () => {
const found = findAdSegmentAtTime(mergedSegments, 20)
expect(found).not.toBeNull()
expect(found?.startTime).toBe(10)
expect(found?.endTime).toBe(30)
})
test('finds ad segment at start time (inclusive)', () => {
const found = findAdSegmentAtTime(mergedSegments, 50)
expect(found).not.toBeNull()
expect(found?.startTime).toBe(50)
})
test('does NOT find ad segment at end time (exclusive)', () => {
const found = findAdSegmentAtTime(mergedSegments, 70)
expect(found).toBeNull()
})
test('returns null when time is before all ads', () => {
const found = findAdSegmentAtTime(mergedSegments, 5)
expect(found).toBeNull()
})
test('returns null when time is after all ads', () => {
const found = findAdSegmentAtTime(mergedSegments, 200)
expect(found).toBeNull()
})
test('returns null when time is in gap between ads', () => {
const found = findAdSegmentAtTime(mergedSegments, 80)
expect(found).toBeNull()
})
test('handles empty segment list', () => {
const found = findAdSegmentAtTime([], 50)
expect(found).toBeNull()
})
})
describe('Ad Segments Overlap Check', () => {
test('detects overlapping segments', () => {
const a: AdSegment = { id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' }
const b: AdSegment = { id: 'ad-002', startTime: 20, endTime: 40, taggerPubkey: 'npub1test' }
expect(adSegmentsOverlap(a, b)).toBe(true)
expect(adSegmentsOverlap(b, a)).toBe(true)
})
test('detects touching segments (boundaries meet)', () => {
const a: AdSegment = { id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' }
const b: AdSegment = { id: 'ad-002', startTime: 30, endTime: 50, taggerPubkey: 'npub1test' }
expect(adSegmentsOverlap(a, b)).toBe(false) // Half-open intervals: [10, 30) and [30, 50) don't overlap
})
test('detects non-overlapping segments', () => {
const a: AdSegment = { id: 'ad-001', startTime: 10, endTime: 30, taggerPubkey: 'npub1test' }
const b: AdSegment = { id: 'ad-002', startTime: 50, endTime: 70, taggerPubkey: 'npub1test' }
expect(adSegmentsOverlap(a, b)).toBe(false)
})
})
describe('POC Test Scenarios', () => {
test('Scenario 1: Ad inside a chapter', () => {
// Chapter: 0-300s
// Ad: 100-130s (inside chapter)
const adSegment: AdSegment = {
id: 'ad-001',
startTime: 100,
endTime: 130,
taggerPubkey: 'npub1test',
}
// Ad is valid and not affected by chapter boundaries
const validation = validateAdSegment(adSegment)
expect(validation.valid).toBe(true)
// Chapter remains unchanged (chapters are independent from ads)
const chapterStart = 0
const chapterEnd = 300
// Ad occurs within chapter but doesn't split it
expect(adSegment.startTime).toBeGreaterThanOrEqual(chapterStart)
expect(adSegment.endTime).toBeLessThanOrEqual(chapterEnd)
})
test('Scenario 2: Two overlapping ads merged', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 50, endTime: 80, taggerPubkey: 'npub1test1' },
{ id: 'ad-002', startTime: 70, endTime: 100, taggerPubkey: 'npub1test2' },
]
const merged = mergeAdSegments(segments)
expect(merged).toHaveLength(1)
expect(merged[0].startTime).toBe(50)
expect(merged[0].endTime).toBe(100)
})
test('Scenario 3: Ad touching chapter boundary exactly', () => {
// Chapter 1: 0-120s
// Chapter 2: 120-300s
// Ad: 100-120s (ends exactly at chapter boundary)
const adSegment: AdSegment = {
id: 'ad-001',
startTime: 100,
endTime: 120,
taggerPubkey: 'npub1test',
}
const validation = validateAdSegment(adSegment)
expect(validation.valid).toBe(true)
// Ad is NOT clamped or modified based on chapter boundary
expect(adSegment.endTime).toBe(120)
})
test('Scenario 4: Invalid ad dropped', () => {
const segments: AdSegment[] = [
{ id: 'ad-001', startTime: 10, endTime: 40, taggerPubkey: 'npub1test' }, // Valid
{ id: 'ad-invalid', startTime: 100, endTime: 100, taggerPubkey: 'npub1test' }, // Invalid
{ id: 'ad-003', startTime: 150, endTime: 180, taggerPubkey: 'npub1test' }, // Valid
]
const valid = filterValidAdSegments(segments, false)
const merged = mergeAdSegments(segments)
// Invalid ad should be filtered out
expect(valid).toHaveLength(2)
expect(merged).toHaveLength(2)
// Check that invalid ad is not in results
const invalidIds = merged.flatMap((m) => m.sourceSegmentIds)
expect(invalidIds).not.toContain('ad-invalid')
})
})