enable rust_2018_idioms warning and fix elided-lifetimes-in-paths

Author: stbuehler

src/cidr/any.rs

@@ -211,7 +211,7 @@ impl AnyIpCidr {
 }
 
 impl fmt::Display for AnyIpCidr {
-	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::Any => write!(f, "any"),
 			Self::V4(c) => fmt::Display::fmt(c, f),

src/cidr/combined.rs

@@ -215,7 +215,7 @@ impl Cidr for IpCidr {
 }
 
 impl fmt::Display for IpCidr {
-	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::V4(c) => fmt::Display::fmt(c, f),
 			Self::V6(c) => fmt::Display::fmt(c, f),

src/cidr/direct.rs

@@ -240,13 +240,13 @@ macro_rules! impl_cidr_for {
 		}
 
 		impl fmt::Debug for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				write!(f, "{:?}/{}", self.address, self.network_length)
 			}
 		}
 
 		impl fmt::Display for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				if f.alternate() || !self.is_host_address() {
 					write!(f, "{}/{}", self.address, self.network_length)?;
 				} else {

src/errors.rs

@@ -22,7 +22,7 @@ impl NetworkLengthTooLongError {
 }
 
 impl fmt::Debug for NetworkLengthTooLongError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		write!(
 			w,
 			"Network length {} is too long for {:?} (maximum: {})",
@@ -33,7 +33,7 @@ impl fmt::Debug for NetworkLengthTooLongError {
 	}
 }
 impl fmt::Display for NetworkLengthTooLongError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		fmt::Debug::fmt(self, w)
 	}
 }
@@ -64,7 +64,7 @@ pub enum NetworkParseError {
 	NetworkLengthTooLongError(NetworkLengthTooLongError),
 }
 impl fmt::Debug for NetworkParseError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::InvalidHostPart => write!(w, "host part of address was not zero"),
 			Self::AddrParseError(e) => {
@@ -80,7 +80,7 @@ impl fmt::Debug for NetworkParseError {
 	}
 }
 impl fmt::Display for NetworkParseError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		fmt::Debug::fmt(self, w)
 	}
 }
@@ -132,7 +132,7 @@ pub enum InetTupleError {
 }
 
 impl fmt::Debug for InetTupleError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::NotInSharedNetwork => write!(w, "addresses not in shared network"),
 			Self::NetworkLengthTooLongError(e) => {
@@ -143,7 +143,7 @@ impl fmt::Debug for InetTupleError {
 }
 
 impl fmt::Display for InetTupleError {
-	fn fmt(&self, w: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, w: &mut fmt::Formatter<'_>) -> fmt::Result {
 		fmt::Debug::fmt(self, w)
 	}
 }

src/inet/combined.rs

@@ -249,7 +249,7 @@ impl Inet for IpInet {
 }
 
 impl fmt::Display for IpInet {
-	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::V4(c) => fmt::Display::fmt(c, f),
 			Self::V6(c) => fmt::Display::fmt(c, f),

src/inet/direct.rs

@@ -272,13 +272,13 @@ macro_rules! impl_inet_for {
 		}
 
 		impl fmt::Debug for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				write!(f, "{:?}/{}", self.address, self.network_length)
 			}
 		}
 
 		impl fmt::Display for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				if f.alternate() || !self.is_host_address() {
 					write!(f, "{}/{}", self.address, self.network_length)?;
 				} else {

src/inet_pair/combined.rs

@@ -216,7 +216,7 @@ impl InetPair for IpInetPair {
 }
 
 impl fmt::Display for IpInetPair {
-	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
 			Self::V4(c) => fmt::Display::fmt(c, f),
 			Self::V6(c) => fmt::Display::fmt(c, f),

src/inet_pair/direct.rs

@@ -173,7 +173,7 @@ macro_rules! impl_inet_pair_for {
 		}
 
 		impl fmt::Debug for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				f.debug_struct(stringify!($n))
 					.field("first", &self.first())
 					.field("second", &self.second())
@@ -182,7 +182,7 @@ macro_rules! impl_inet_pair_for {
 		}
 
 		impl fmt::Display for $n {
-			fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+			fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 				use core::fmt::Write;
 				f.write_char('(')?;
 				self.first().fmt(f)?;

src/lib.rs

@@ -1,6 +1,7 @@
 #![cfg_attr(doc_cfg, feature(doc_cfg))]
 #![cfg_attr(not(feature = "std"), no_std)]
 #![warn(missing_docs)]
+#![warn(rust_2018_idioms)]
 #![doc(html_root_url = "https://docs.rs/cidr/0.2.1")]
 #![allow(clippy::match_like_matches_macro)]
 

src/serde_common.rs

@@ -90,7 +90,7 @@ where
 	impl<'de> de::Visitor<'de> for Visitor {
 		type Value = Option<(IpAddr, u8)>;
 
-		fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
+		fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
 			formatter.write_str("a tuple with two fields")
 		}
 
@@ -131,7 +131,7 @@ where
 	impl<'de> de::Visitor<'de> for NewTypeVisitor {
 		type Value = Option<(IpAddr, u8)>;
 
-		fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
+		fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
 			formatter.write_str("newtype `")?;
 			formatter.write_str(self.0)?;
 			formatter.write_str("`")