Fix no_std support #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Doron <[email protected]>
* Serde can be used with "alloc" feature only. * Error can be implemented now with Error Signed-off-by: Jon Doron <[email protected]>
Owner
|
Hi, thanks for this pull request. I'm gonna take fixing the For the remaining part I'm a bit unsure.
So technically we require |
Owner
|
Given rust-1.81 is already required and is about the same age as serde 1.0.210 I decided to raise the serde version requirement. |
stbuehler
added a commit
that referenced
this pull request
Jan 18, 2025
Serde impls for Ip*Addr from serde 1.0.210 don't require std (if used with rust>=1.77, which we require anyway).
Owner
|
Applied in f0b716c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the no_std support to work for the Error type and serde as well