Skip to content

Commit c0fb0f4

Browse files
stdlib-botstdlib-bot
committed
Auto-generated commit
1 parent 02fb240 commit c0fb0f4

File tree

10 files changed

+24
-118
lines changed

10 files changed

+24
-118
lines changed

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,12 @@ A total of 33 issues were closed in this release:
256256

257257
<details>
258258

259+
- [`582ef31`](https://github.com/stdlib-js/stdlib/commit/582ef3182ea40031f2bff23af519b1a7e7952d57) - **refactor:** wrap `blas/ext/base/gjoin` _(by Athan Reines)_
260+
- [`5f49874`](https://github.com/stdlib-js/stdlib/commit/5f498740352d6ac14ac7a8df0284e640c21c2f12) - **bench:** refactor to use string interpolation in `array/base/binary3d` [(#8803)](https://github.com/stdlib-js/stdlib/pull/8803) _(by Kate Suraev)_
261+
- [`34c2666`](https://github.com/stdlib-js/stdlib/commit/34c2666e48e25c5a508aeae1337f666a3b404684) - **bench:** refactor to use string interpolation in `array/base/binary4d` [(#8804)](https://github.com/stdlib-js/stdlib/pull/8804) _(by Kate Suraev)_
262+
- [`e61d351`](https://github.com/stdlib-js/stdlib/commit/e61d351ccb623f92717c726b0dad660df25e9eb6) - **bench:** refactor to use string interpolation in `array/base/binary5d` [(#8805)](https://github.com/stdlib-js/stdlib/pull/8805) _(by Kate Suraev)_
263+
- [`a2b58c3`](https://github.com/stdlib-js/stdlib/commit/a2b58c373dc63124d0ba75dd22697b11c998d361) - **bench:** refactor to use string interpolation in `array/base/binarynd` [(#8806)](https://github.com/stdlib-js/stdlib/pull/8806) _(by Kate Suraev)_
264+
- [`f11ec58`](https://github.com/stdlib-js/stdlib/commit/f11ec582954487ae134d60517caf8ab6b908208e) - **bench:** refactor to use string interpolation in `array/base/broadcast-array` [(#8807)](https://github.com/stdlib-js/stdlib/pull/8807) _(by Kate Suraev)_
259265
- [`6dcee29`](https://github.com/stdlib-js/stdlib/commit/6dcee29958b1d4e11445247099549a8fcf06710c) - **bench:** refactor to use string interpolation in `array/base/broadcasted-binary2d` [(#8808)](https://github.com/stdlib-js/stdlib/pull/8808) _(by Kate Suraev)_
260266
- [`e90c33d`](https://github.com/stdlib-js/stdlib/commit/e90c33d923ee90a55993a02d5b3802a8f83c7ee4) - **bench:** refactor to use string interpolation in `array/base/broadcasted-binary3d` [(#8809)](https://github.com/stdlib-js/stdlib/pull/8809) _(by Kate Suraev)_
261267
- [`b7e39fd`](https://github.com/stdlib-js/stdlib/commit/b7e39fd40f3113966cdb40d479f73825cd23b1e4) - **bench:** refactor to use string interpolation in `array/base/binary2d` [(#8802)](https://github.com/stdlib-js/stdlib/pull/8802) _(by Kate Suraev)_

‎base/binary3d/benchmark/benchmark.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filled3dBy = require( './../../../base/filled3d-by' );
3030
var zeros3d = require( './../../../base/zeros3d' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binary3d = require( './../lib' );
3435

@@ -114,7 +115,7 @@ function main() {
114115
N = floor( pow( pow( 10, i ), 1.0/3.0 ) );
115116
sh = [ N, N, N ];
116117
f = createBenchmark( sh );
117-
bench( pkg+'::equidimensional:size='+numel( sh ), f );
118+
bench( format( '%s::equidimensional:size=%d', pkg, numel( sh ) ), f );
118119
}
119120
}
120121

‎base/binary4d/benchmark/benchmark.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filled4dBy = require( './../../../base/filled4d-by' );
3030
var zeros4d = require( './../../../base/zeros4d' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binary4d = require( './../lib' );
3435

@@ -117,7 +118,7 @@ function main() {
117118
N = floor( pow( pow( 10, i ), 1.0/4.0 ) );
118119
sh = [ N, N, N, N ];
119120
f = createBenchmark( sh );
120-
bench( pkg+'::equidimensional:size='+numel( sh ), f );
121+
bench( format( '%s::equidimensional:size=%d', pkg, numel( sh ) ), f );
121122
}
122123
}
123124

‎base/binary5d/benchmark/benchmark.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filled5dBy = require( './../../../base/filled5d-by' );
3030
var zeros5d = require( './../../../base/zeros5d' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binary5d = require( './../lib' );
3435

@@ -120,7 +121,7 @@ function main() {
120121
N = floor( pow( pow( 10, i ), 1.0/5.0 ) );
121122
sh = [ N, N, N, N, N ];
122123
f = createBenchmark( sh );
123-
bench( pkg+'::equidimensional:size='+numel( sh ), f );
124+
bench( format( '%s::equidimensional:size=%d', pkg, numel( sh ) ), f );
124125
}
125126
}
126127

‎base/binarynd/benchmark/benchmark.size.2d.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filledndBy = require( './../../../base/fillednd-by' );
3030
var zerosnd = require( './../../../base/zerosnd' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binarynd = require( './../lib' );
3435

@@ -111,7 +112,7 @@ function main() {
111112
N = floor( pow( pow( 10, i ), 1.0/2.0 ) );
112113
sh = [ N, N ];
113114
f = createBenchmark( sh );
114-
bench( pkg+'::2d,equidimensional:size='+numel( sh ), f );
115+
bench( format( '%s::2d,equidimensional:size=%d', pkg, numel( sh ) ), f );
115116
}
116117
}
117118

‎base/binarynd/benchmark/benchmark.size.3d.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filledndBy = require( './../../../base/fillednd-by' );
3030
var zerosnd = require( './../../../base/zerosnd' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binarynd = require( './../lib' );
3435

@@ -114,7 +115,7 @@ function main() {
114115
N = floor( pow( pow( 10, i ), 1.0/3.0 ) );
115116
sh = [ N, N, N ];
116117
f = createBenchmark( sh );
117-
bench( pkg+'::3d,equidimensional:size='+numel( sh ), f );
118+
bench( format( '%s::3d,equidimensional:size=%d', pkg, numel( sh ) ), f );
118119
}
119120
}
120121

‎base/binarynd/benchmark/benchmark.size.4d.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filledndBy = require( './../../../base/fillednd-by' );
3030
var zerosnd = require( './../../../base/zerosnd' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binarynd = require( './../lib' );
3435

@@ -117,7 +118,7 @@ function main() {
117118
N = floor( pow( pow( 10, i ), 1.0/4.0 ) );
118119
sh = [ N, N, N, N ];
119120
f = createBenchmark( sh );
120-
bench( pkg+'::4d,equidimensional:size='+numel( sh ), f );
121+
bench( format( '%s::4d,equidimensional:size=%d', pkg, numel( sh ) ), f );
121122
}
122123
}
123124

‎base/binarynd/benchmark/benchmark.size.5d.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var add = require( '@stdlib/number/float64/base/add' );
2929
var filledndBy = require( './../../../base/fillednd-by' );
3030
var zerosnd = require( './../../../base/zerosnd' );
3131
var numel = require( '@stdlib/ndarray/base/numel' );
32+
var format = require( '@stdlib/string/format' );
3233
var pkg = require( './../package.json' ).name;
3334
var binarynd = require( './../lib' );
3435

@@ -120,7 +121,7 @@ function main() {
120121
N = floor( pow( pow( 10, i ), 1.0/5.0 ) );
121122
sh = [ N, N, N, N, N ];
122123
f = createBenchmark( sh );
123-
bench( pkg+'::5d,equidimensional:size='+numel( sh ), f );
124+
bench( format( '%s::5d,equidimensional:size=%d', pkg, numel( sh ) ), f );
124125
}
125126
}
126127

‎base/broadcast-array/benchmark/benchmark.dimensions.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ var bench = require( '@stdlib/bench' );
2424
var isArray = require( '@stdlib/assert/is-array' );
2525
var isEven = require( '@stdlib/math/base/assert/is-even' );
2626
var zerosnd = require( './../../../base/zerosnd' );
27+
var format = require( '@stdlib/string/format' );
2728
var pkg = require( './../package.json' ).name;
2829
var broadcastArray = require( './../lib' );
2930

@@ -109,7 +110,7 @@ function main() {
109110

110111
for ( i = min; i <= max; i++ ) {
111112
f = createBenchmark( i );
112-
bench( pkg+':dimensions='+i, f );
113+
bench( format( '%s:dimensions=%d', pkg, i ), f );
113114
}
114115
}
115116

‎base/join/lib/main.js‎

Lines changed: 2 additions & 110 deletions
Original file line numberDiff line numberDiff line change
@@ -20,107 +20,7 @@
2020

2121
// MODULES //
2222

23-
var arraylike2object = require( './../../../base/arraylike2object' );
24-
var isUndefinedOrNull = require( '@stdlib/assert/is-undefined-or-null' );
25-
26-
27-
// FUNCTIONS //
28-
29-
/**
30-
* Tests whether an object has a specified method.
31-
*
32-
* @private
33-
* @param {Object} obj - input object
34-
* @param {string} method - method name
35-
* @returns {boolean} boolean indicating whether an object has a specified method
36-
*
37-
* @example
38-
* var bool = hasMethod( [], 'join' );
39-
* // returns true
40-
*
41-
* @example
42-
* var bool = hasMethod( [], 'beep' );
43-
* // returns false
44-
*/
45-
function hasMethod( obj, method ) {
46-
return ( typeof obj[ method ] === 'function' );
47-
}
48-
49-
/**
50-
* Returns a string created by joining elements in an accessor array using a specified separator.
51-
*
52-
* @private
53-
* @param {Object} x - input array object
54-
* @param {integer} separator - separator
55-
* @returns {string} output string
56-
*
57-
* @example
58-
* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
59-
* var arraylike2object = require( '@stdlib/array/base/arraylike2object' );
60-
*
61-
* var x = arraylike2object( toAccessorArray( [ 1, 2, 3, 4 ] ) );
62-
*
63-
* var out = accessors( x, ',' );
64-
* // returns '1,2,3,4'
65-
*/
66-
function accessors( x, separator ) {
67-
var data;
68-
var out;
69-
var get;
70-
var N;
71-
var v;
72-
var i;
73-
74-
data = x.data;
75-
get = x.accessors[ 0 ];
76-
77-
N = data.length - 1;
78-
out = '';
79-
for ( i = 0; i <= N; i++ ) {
80-
v = get( data, i );
81-
if ( !isUndefinedOrNull( v ) ) {
82-
out += String( v );
83-
}
84-
if ( i < N ) {
85-
out += separator;
86-
}
87-
}
88-
return out;
89-
}
90-
91-
/**
92-
* Returns a string created by manually joining array elements using a specified separator.
93-
*
94-
* @private
95-
* @param {Object} x - input array object
96-
* @param {integer} separator - separator
97-
* @returns {string} output string
98-
*
99-
* @example
100-
* var x = [ 1, 2, 3, 4 ];
101-
*
102-
* var out = indexed( x, ',' );
103-
* // returns '1,2,3,4'
104-
*/
105-
function indexed( x, separator ) {
106-
var out;
107-
var N;
108-
var v;
109-
var i;
110-
111-
N = x.length - 1;
112-
out = '';
113-
for ( i = 0; i <= N; i++ ) {
114-
v = x[ i ];
115-
if ( !isUndefinedOrNull( v ) ) {
116-
out += String( v );
117-
}
118-
if ( i < N ) {
119-
out += separator;
120-
}
121-
}
122-
return out;
123-
}
23+
var strided = require( '@stdlib/blas/ext/base/gjoin' ).ndarray;
12424

12525

12626
// MAIN //
@@ -145,15 +45,7 @@ function indexed( x, separator ) {
14545
* // returns '1-2-3---4'
14646
*/
14747
function join( x, separator ) {
148-
var obj;
149-
if ( hasMethod( x, 'join' ) ) {
150-
return x.join( separator );
151-
}
152-
obj = arraylike2object( x );
153-
if ( obj.accessorProtocol ) {
154-
return accessors( obj, separator );
155-
}
156-
return indexed( x, separator );
48+
return strided( x.length, separator, x, 1, 0 );
15749
}
15850

15951

0 commit comments

Comments
 (0)