Skip to content

Commit 4bbe41b

Browse files
committed
review: docs — fixture chunk wording, publish prefix results/, explicit hours unit
1 parent f5b788d commit 4bbe41b

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ campaigns on an AWS NVMe devbox (`m6id.2xlarge`), driven by the config-driven ru
1414
[`runner/`](runner/) (see "Run a campaign" below). Each campaign is several configurations
1515
× 5 fresh-process runs; every run writes CSVs
1616
(`stage,n,n_items,total_ns,p50_ns,p90_ns,p99_ns,max_ns`) into its own directory, and the
17-
results are mirrored to GCS under `gs://rpc-full-history/benchmarks/`.
17+
results are mirrored to GCS under `gs://rpc-full-history/results/`.
1818

1919
`converter/convert.py` (Python 3, standard library only) turns one results directory into
2020
`docs/runs/<run-id>.json` (schema v1) and updates the manifest `docs/runs/index.json`. The
@@ -86,7 +86,7 @@ go run ./cmd/campaign run my-campaign.toml
8686
# bundle lacks survive it. Against a destination that really is empty,
8787
# --force only skips the emptiness check, so it is safe on a first publish):
8888
go run ./cmd/campaign publish /mnt/nvme/bench/results/<run-id> \
89-
gs://rpc-full-history/benchmarks --force
89+
gs://rpc-full-history/results --force
9090
```
9191

9292
The published bundle is exactly what the next section ingests into a committed run

runner/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ that root is materialized:
143143
`$BENCH_ROOT/golden/<name>/` and reused by later campaigns.
144144
- **`bsb-s3`**`location` is an S3 bucket path; an untimed cold backfill materializes
145145
`$BENCH_ROOT/golden/<name>/`, one chunk at a time.
146-
- **`fixture`** — no location and no network: `ledgers` chunks are generated, then an
147-
untimed cold ingest freezes them into `$BENCH_ROOT/golden/<name>/`.
146+
- **`fixture`** — no location and no network: each chunk in `chunks` is generated with
147+
`ledgers` ledgers, then an untimed cold ingest freezes them into
148+
`$BENCH_ROOT/golden/<name>/`.
148149

149150
Anything the runner materializes is built under `<root>.partial` and renamed onto
150151
`<root>` only once whole, so an interrupted preparation is never mistaken for a finished
@@ -244,7 +245,7 @@ root, survives an instance stop) and, when `publish_uri` is set, uploaded to
244245
## Resuming a crashed campaign
245246

246247
A campaign is hours of work — the phase-1 reference run took ~17 hours, with single
247-
hot-ingest legs near 5.5 — so a crash or an OOM kill at the last rep should not cost the
248+
hot-ingest legs near 5.5 hours — so a crash or an OOM kill at the last rep should not cost the
248249
whole thing. `--resume` continues into the existing results directory instead of starting
249250
a new one:
250251

runner/example-campaign.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ query = false
6565
# Publish the finished bundle to object storage (gs:// or s3://) at the end of
6666
# the campaign. Default "" = keep results local; publish later by hand with
6767
# `campaign publish <bundle> <dest-root>`.
68-
#publish_uri = "gs://rpc-full-history/benchmarks"
68+
#publish_uri = "gs://rpc-full-history/results"
6969

7070
# Datasets to benchmark: one [[dataset]] table each, with a unique name and the
7171
# chunk IDs this campaign runs. Every kind converges on a local cold pack root

0 commit comments

Comments
 (0)