Commit 5c313c8
fix(e2e): assert the sheets are gone rather than what sits behind them
Both post-dismiss waits checked an element behind the sheet being
dismissed — home-screen after the welcome sheet, home-account-switcher
after the manage-accounts sheet. Maestro does not occlusion-test, which
is the same property that caused the original bug (the account-switcher
tap reported COMPLETED while the welcome sheet covered it), so those
elements resolve as visible the entire time the sheet is up and the
waits passed instantly without confirming anything.
Wait on each sheet's own control disappearing instead. This closes the
window where the next tap fires while the sheet is still animating out
and gets swallowed, costing a 15s timeout and a retry attempt. Matches
the notVisible idiom already used for the paste dialog and the
forgot-password modal.
Hygiene rather than a fix for anything observed: OpenManageAccountsSheet
completed successfully in all 7 iOS retries across the 10-round soak.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 04abe35 commit 5c313c8
1 file changed
Lines changed: 8 additions & 4 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
37 | 41 | | |
38 | | - | |
39 | | - | |
| 42 | + | |
| 43 | + | |
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| |||
49 | 53 | | |
50 | 54 | | |
51 | 55 | | |
52 | | - | |
53 | | - | |
| 56 | + | |
| 57 | + | |
54 | 58 | | |
55 | 59 | | |
56 | 60 | | |
| |||
0 commit comments