Skip to content

Commit 5c313c8

Browse files
CassioMGclaude
andcommitted
fix(e2e): assert the sheets are gone rather than what sits behind them
Both post-dismiss waits checked an element behind the sheet being dismissed — home-screen after the welcome sheet, home-account-switcher after the manage-accounts sheet. Maestro does not occlusion-test, which is the same property that caused the original bug (the account-switcher tap reported COMPLETED while the welcome sheet covered it), so those elements resolve as visible the entire time the sheet is up and the waits passed instantly without confirming anything. Wait on each sheet's own control disappearing instead. This closes the window where the next tap fires while the sheet is still animating out and gets swallowed, costing a 15s timeout and a retry attempt. Matches the notVisible idiom already used for the paste dialog and the forgot-password modal. Hygiene rather than a fix for anything observed: OpenManageAccountsSheet completed successfully in all 7 iOS retries across the 10-round soak. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 04abe35 commit 5c313c8

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎e2e/flows/shared/OpenManageAccountsSheet.yaml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,13 @@ appId: org.stellar.freighterdev
3434
commands:
3535
- tapOn:
3636
id: welcome-banner-dismiss-button
37+
# Wait on the sheet's own control disappearing, not on something
38+
# behind it: Maestro does not occlusion-test, so the home screen
39+
# resolves as visible the whole time the sheet is up and asserting
40+
# on it would pass instantly without confirming anything.
3741
- extendedWaitUntil:
38-
visible:
39-
id: home-screen
42+
notVisible:
43+
id: welcome-banner-dismiss-button
4044
timeout: 15000
4145

4246
# If a previous attempt got as far as opening the manage-accounts sheet,
@@ -49,8 +53,8 @@ appId: org.stellar.freighterdev
4953
- tapOn:
5054
id: manage-accounts-close-button
5155
- extendedWaitUntil:
52-
visible:
53-
id: home-account-switcher
56+
notVisible:
57+
id: manage-accounts-close-button
5458
timeout: 15000
5559

5660
# An "Account not loaded" toast can also overlay the top of the header.

0 commit comments

Comments
 (0)