Skip to content

Commit c714abc

Browse files
authored
[E2E] Remove /e2e comment trigger from CI workflows (#720)
1 parent fd40d29 commit c714abc

4 files changed

Lines changed: 12 additions & 45 deletions

File tree

‎.github/workflows/android-e2e.yml‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ on:
66
types: [opened, synchronize, reopened, ready_for_review]
77
push:
88
branches: [main, release, "v*.*.*"]
9-
issue_comment:
10-
types: [created]
119
workflow_dispatch:
1210
inputs:
1311
ref:
@@ -77,19 +75,11 @@ jobs:
7775
name: Build Android APK
7876
runs-on: ubuntu-latest-16-cores
7977
timeout-minutes: 120
80-
# Run on PR "/e2e" comments, or on normal triggers (PR, push, workflow_dispatch)
81-
if: |
82-
(github.event_name == 'issue_comment' && github.event.issue.pull_request && github.event.comment.body == '/e2e') ||
83-
github.event_name != 'issue_comment'
84-
8578
steps:
8679
- name: Checkout repo
8780
uses: actions/checkout@v5
8881
with:
89-
ref:
90-
${{ github.event.inputs.ref || (github.event_name == 'issue_comment'
91-
&& format('refs/pull/{0}/head', github.event.issue.number)) ||
92-
github.ref }}
82+
ref: ${{ github.event.inputs.ref || github.ref }}
9383

9484
- name: Make scripts executable
9585
run: find scripts -type f -exec chmod +x {} \;
@@ -240,10 +230,7 @@ jobs:
240230
- name: Checkout repo
241231
uses: actions/checkout@v5
242232
with:
243-
ref:
244-
${{ github.event.inputs.ref || (github.event_name == 'issue_comment'
245-
&& format('refs/pull/{0}/head', github.event.issue.number)) ||
246-
github.ref }}
233+
ref: ${{ github.event.inputs.ref || github.ref }}
247234

248235
- name: Make scripts executable
249236
run: find scripts -type f -exec chmod +x {} \;

‎.github/workflows/ios-e2e.yml‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ on:
66
types: [opened, synchronize, reopened, ready_for_review]
77
push:
88
branches: [main, release, "v*.*.*"]
9-
issue_comment:
10-
types: [created]
119
workflow_dispatch:
1210
inputs:
1311
ref:
@@ -69,19 +67,11 @@ jobs:
6967
name: Build iOS App
7068
runs-on: macos-26-xlarge
7169
timeout-minutes: 120
72-
# Run on PR "/e2e" comments, or on normal triggers (PR, push, workflow_dispatch)
73-
if: |
74-
(github.event_name == 'issue_comment' && github.event.issue.pull_request && github.event.comment.body == '/e2e') ||
75-
github.event_name != 'issue_comment'
76-
7770
steps:
7871
- name: Checkout repo
7972
uses: actions/checkout@v5
8073
with:
81-
ref:
82-
${{ github.event.inputs.ref || (github.event_name == 'issue_comment'
83-
&& format('refs/pull/{0}/head', github.event.issue.number)) ||
84-
github.ref }}
74+
ref: ${{ github.event.inputs.ref || github.ref }}
8575

8676
- name: Make scripts executable
8777
run: find scripts -type f -exec chmod +x {} \;
@@ -237,10 +227,7 @@ jobs:
237227
- name: Checkout repo
238228
uses: actions/checkout@v5
239229
with:
240-
ref:
241-
${{ github.event.inputs.ref || (github.event_name == 'issue_comment'
242-
&& format('refs/pull/{0}/head', github.event.issue.number)) ||
243-
github.ref }}
230+
ref: ${{ github.event.inputs.ref || github.ref }}
244231

245232
- name: Make scripts executable
246233
run: find scripts -type f -exec chmod +x {} \;

‎e2e/README.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ E2E tests run **locally** (with Maestro CLI + simulator/emulator) or in **CI**
4646

4747
Detailed guides live in `e2e/docs/`:
4848

49-
| Topic | File | Description |
50-
| ------------------------- | ------------------------------------------------------------- | ---------------------------------------------------------------------------------------------- |
51-
| **CI & Triggers** | [ci-and-triggers.md](docs/ci-and-triggers.md) | When tests run, branch filters, manual runs (workflow_dispatch, `/e2e`), CI matrix parallelism |
52-
| **Local Setup & Env** | [local-setup-and-env.md](docs/local-setup-and-env.md) | `.env` for E2E, `E2E_TEST_RECOVERY_PHRASE`, how secrets/vars are used in CI |
53-
| **Running Tests** | [running-tests.md](docs/running-tests.md) | Run in CI vs locally, single flow by platform + name |
54-
| **Artifacts & Debugging** | [artifacts-and-debugging.md](docs/artifacts-and-debugging.md) | Artifact layout, logs, recordings, screenshots, how to debug failures |
55-
| **Creating Tests** | [creating-tests.md](docs/creating-tests.md) | Maestro YAML (API), Maestro Studio, recording flows, best practices (e.g. prefer `testID`) |
49+
| Topic | File | Description |
50+
| ------------------------- | ------------------------------------------------------------- | ------------------------------------------------------------------------------------------ |
51+
| **CI & Triggers** | [ci-and-triggers.md](docs/ci-and-triggers.md) | When tests run, branch filters, manual runs (workflow_dispatch), CI matrix parallelism |
52+
| **Local Setup & Env** | [local-setup-and-env.md](docs/local-setup-and-env.md) | `.env` for E2E, `E2E_TEST_RECOVERY_PHRASE`, how secrets/vars are used in CI |
53+
| **Running Tests** | [running-tests.md](docs/running-tests.md) | Run in CI vs locally, single flow by platform + name |
54+
| **Artifacts & Debugging** | [artifacts-and-debugging.md](docs/artifacts-and-debugging.md) | Artifact layout, logs, recordings, screenshots, how to debug failures |
55+
| **Creating Tests** | [creating-tests.md](docs/creating-tests.md) | Maestro YAML (API), Maestro Studio, recording flows, best practices (e.g. prefer `testID`) |
5656

5757
---
5858

‎e2e/docs/ci-and-triggers.md‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ covers when they run, how to trigger them manually, and how the CI matrix works.
99
flowchart TD
1010
PR[Pull request] --> BR{Target branch?}
1111
PU[Push] --> BR
12-
IC[Comment /e2e on PR] --> RUN
1312
WD[workflow_dispatch] --> RUN
1413
BR --> |main, release, v*.*.*| RUN[Run E2E workflow]
1514
BR --> |Other| SKIP[Skip]
@@ -19,26 +18,20 @@ flowchart TD
1918
| --------------------- | -------------------------------------------------------------------------------------------------- |
2019
| **Pull request** | `opened`, `synchronize`, `reopened`, `ready_for_review` on `main`, `release`, or `v*.*.*` branches |
2120
| **Push** | Same branches as above |
22-
| **Issue comment** | Comment **exactly** `/e2e` on a PR (runs on that PR's head) |
2321
| **workflow_dispatch** | Manual run from **Actions** tab |
2422

2523
**Branch patterns**: `v*.*.*` matches semantic versions (e.g. `v1.2.3`), not
2624
arbitrary names like `vrandombranch`.
2725

2826
## Manual runs
2927

30-
### 1. workflow_dispatch
28+
Use **workflow_dispatch** to run E2E tests on demand:
3129

3230
1. Open **Actions** → **Android E2E Tests** or **iOS E2E Tests**.
3331
2. Click **Run workflow**.
3432
3. Optionally set **ref** (commit hash) or leave empty for default branch.
3533
4. Run.
3634

37-
### 2. Comment `/e2e` on a PR
38-
39-
Comment **exactly** `/e2e` on a pull request. The workflow runs for that PR's
40-
head. Build and test jobs use the same ref.
41-
4235
## CI matrix & parallelism
4336

4437
```mermaid

0 commit comments

Comments
 (0)