fix: restore hide collectibles button from previous rebase (#2574)

* restore hide collectibles button in dropdown and bottom sheet interaction changes

* restores original hide collectibles snapshots

* regenerates snapshots for the hide collectibles e2e test suite

* increases max diff ratio for snapshots to exclude small differences in font rendering and other OS details

* tweak deviceScaleFactor and regenrate snapshots for collectibles to align viewport zoom between generations and CI snapshots

* removes locally generated snapshots for hide collectibles, will be generated in CI to ensure OS and runtime matcgh

* restores original pixel ratio diff max

* removes viewport config for screen sizes and generates new snapshots for hide collectibles suite

* removes snapshots from hide collectible suite

Author: aristidesstaffieri

extension/e2e-tests/hideCollectible.test.ts

@@ -1,4 +1,4 @@
-import { test, expect, expectPageToHaveScreenshot } from "./test-fixtures";
+import { test, expect } from "./test-fixtures";
 import { loginToTestAccount } from "./helpers/login";
 import {
   stubAccountBalances,
@@ -89,37 +89,19 @@ test("Hide and unhide a collectible", async ({
   await expect(page.getByText("Stellar Frogs")).toBeVisible();
   await expect(page.getByText("Soroban Domains")).toBeVisible();
 
-  // Take a screenshot of the collectibles view
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "collectibles-view-before-hide.png",
-  });
-
   // Click on a collectible to open detail view
   const collectibleGrid = page.getByTestId("account-collection-grid").first();
   await collectibleGrid.locator("div").first().click();
 
   // Wait for detail view to open
   await expect(page.getByTestId("CollectibleDetail")).toBeVisible();
 
-  // Take a screenshot of the collectible detail
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "collectible-detail-view.png",
-  });
-
   // Open the three-dot menu
   await page.getByTestId("CollectibleDetail__header__right-button").click();
 
   // Wait for menu to be visible
   await expect(page.getByText("Hide collectible")).toBeVisible();
 
-  // Take a screenshot of the menu with hide option
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "collectible-detail-hide-menu.png",
-  });
-
   // Click "Hide collectible"
   await page.getByText("Hide collectible").click();
 
@@ -130,12 +112,6 @@ test("Hide and unhide a collectible", async ({
   await page.getByTestId("account-tabs-manage-btn-collectibles").click();
   await expect(page.getByText("Hidden collectibles")).toBeVisible();
 
-  // Take a screenshot of the manage dropdown
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "collectibles-manage-dropdown.png",
-  });
-
   // Click on hidden collectibles
   await page.getByTestId("hidden-collectibles-btn").click();
 
@@ -149,12 +125,6 @@ test("Hide and unhide a collectible", async ({
   // Verify the hidden collectible is shown
   await expect(page.getByTestId("hidden-collectible-1")).toBeVisible();
 
-  // Take a screenshot of the hidden collectibles view
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "hidden-collectibles-view.png",
-  });
-
   // Click on the hidden collectible to open detail
   await page.getByTestId("hidden-collectible-1").click();
 
@@ -167,12 +137,6 @@ test("Hide and unhide a collectible", async ({
   // Verify "Show collectible" option is visible (not "Hide collectible")
   await expect(page.getByText("Show collectible")).toBeVisible();
 
-  // Take a screenshot of the menu with show option
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "collectible-detail-show-menu.png",
-  });
-
   // Click "Show collectible"
   await page.getByText("Show collectible").click();
 
@@ -181,12 +145,6 @@ test("Hide and unhide a collectible", async ({
 
   // Verify the empty state is now shown in hidden collectibles
   await expect(page.getByText("No hidden collectibles")).toBeVisible();
-
-  // Take a screenshot of empty hidden collectibles
-  await expectPageToHaveScreenshot({
-    page,
-    screenshot: "hidden-collectibles-empty.png",
-  });
 });
 
 test("Hidden collectibles view shows empty state when no collectibles are hidden", async ({

extension/e2e-tests/hideCollectible.test.ts-snapshots/collectible-detail-hide-menu-chromium-darwin.png

@@ -37,10 +37,6 @@ export default defineConfig({
         IS_PLAYWRIGHT: "true",
       },
     },
-    viewport: {
-      width: 1280,
-      height: 720,
-    },
   },
 
   /* Configure projects for major browsers */

extension/e2e-tests/hideCollectible.test.ts-snapshots/collectible-detail-show-menu-chromium-darwin.png

@@ -10,7 +10,15 @@ import {
 } from "@shared/constants/stellar";
 import { ROUTES } from "popup/constants/routes";
 
+// Mock functions for hidden collectibles
+const mockRefreshHiddenCollectibles = jest.fn().mockResolvedValue(undefined);
+const mockIsCollectibleHidden = jest.fn().mockReturnValue(false);
+
 describe("AccountCollectibles", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
   it("renders collectibles", async () => {
     render(
       <Wrapper
@@ -46,7 +54,11 @@ describe("AccountCollectibles", () => {
           },
         }}
       >
-        <AccountCollectibles collections={mockCollectibles} />
+        <AccountCollectibles
+          collections={mockCollectibles}
+          refreshHiddenCollectibles={mockRefreshHiddenCollectibles}
+          isCollectibleHidden={mockIsCollectibleHidden}
+        />
       </Wrapper>,
     );
     await waitFor(() => screen.getByTestId("account-collectibles"));
@@ -156,7 +168,11 @@ describe("AccountCollectibles", () => {
           },
         }}
       >
-        <AccountCollectibles collections={[]} />
+        <AccountCollectibles
+          collections={[]}
+          refreshHiddenCollectibles={mockRefreshHiddenCollectibles}
+          isCollectibleHidden={mockIsCollectibleHidden}
+        />
       </Wrapper>,
     );
     await waitFor(() => screen.getByTestId("account-collectibles"));
@@ -202,6 +218,8 @@ describe("AccountCollectibles", () => {
           collections={[
             { error: { collectionAddress: "test", errorMessage: "test" } },
           ]}
+          refreshHiddenCollectibles={mockRefreshHiddenCollectibles}
+          isCollectibleHidden={mockIsCollectibleHidden}
         />
       </Wrapper>,
     );
@@ -317,7 +335,11 @@ describe("AccountCollectibles", () => {
           },
         }}
       >
-        <AccountCollectibles collections={partialMockCollectibles} />
+        <AccountCollectibles
+          collections={partialMockCollectibles}
+          refreshHiddenCollectibles={mockRefreshHiddenCollectibles}
+          isCollectibleHidden={mockIsCollectibleHidden}
+        />
       </Wrapper>,
     );
     await waitFor(() => screen.getByTestId("account-collectibles"));