fix(earn): extract the pool description for translation

Author: aristidesstaffieri

extension/src/popup/components/earn/PoolDetailsSheet/poolDescriptions.ts

@@ -1,3 +1,5 @@
+import { BLEND_FIXED_POOL_IDS } from "@shared/constants/blend";
+import { NETWORKS } from "@shared/constants/stellar";
 import i18n from "popup/helpers/localizationConfig";
 
 /**
@@ -9,18 +11,29 @@ import i18n from "popup/helpers/localizationConfig";
  * admin account is burned (master weight 0, no signers, all thresholds 0), so
  * "no admin" is a fact about that pool, not about Blend pools in general.
  *
+ * Each entry is a thunk holding a literal `i18n.t` call, for two reasons. The
+ * i18next scanner extracts keys by reading the literal argument of a `t()` call
+ * (see `func.list` in webpack.extension.js), so passing a variable — a string
+ * looked up out of this map — extracts nothing: the key never lands in
+ * translation.json, i18next falls back to returning the key itself, and the copy
+ * renders in English in every language while looking correct in en. And the
+ * thunk keeps resolution lazy, where a bare `i18n.t` at module scope would run
+ * before the language bundle has loaded.
+ *
  * A pool with no entry renders no description rather than a wrong one.
  */
-const POOL_DESCRIPTION_KEYS: Record<string, string> = {
+const POOL_DESCRIPTIONS: Record<string, () => string> = {
   // Fixed Pool v2 — mainnet
-  CAJJZSGMMM3PD7N33TAPHGBUGTB43OC73HVIK2L2G6BNGGGYOSSYBXBD:
-    "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
+  [BLEND_FIXED_POOL_IDS[NETWORKS.PUBLIC]!]: () =>
+    i18n.t(
+      "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
+    ),
   // Fixed Pool v2 — testnet
-  CCEBVDYM32YNYCVNRXQKDFFPISJJCV557CDZEIRBEE4NCV4KHPQ44HGF:
-    "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
+  [BLEND_FIXED_POOL_IDS[NETWORKS.TESTNET]!]: () =>
+    i18n.t(
+      "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
+    ),
 };
 
-export const getPoolDescription = (poolId: string): string | null => {
-  const description = POOL_DESCRIPTION_KEYS[poolId];
-  return description ? i18n.t(description) : null;
-};
+export const getPoolDescription = (poolId: string): string | null =>
+  POOL_DESCRIPTIONS[poolId]?.() ?? null;

extension/src/popup/locales/__tests__/translationParity.test.ts

@@ -51,6 +51,10 @@ const earnKeys = [
   "Add XLM to your wallet to continue",
   "Transaction failed. Try again.",
   "Pool Details",
+  // Reached through a lookup table rather than a literal `t()` argument, so the
+  // scanner cannot see it — the one earn string that has to be listed here to
+  // stay extracted. See PoolDetailsSheet/poolDescriptions.ts.
+  "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
   "Lending Interest",
   "Current Net APY",
   "Accepted tokens",

extension/src/popup/locales/en/translation.json

@@ -478,6 +478,7 @@
   "Password": "Password",
   "Path": "Path",
   "Payment token logo": "Payment token logo",
+  "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.": "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.",
   "Pin Freighter to the toolbar": "Pin Freighter to the toolbar",
   "Please check if the network information is correct and try again.": "Please check if the network information is correct and try again.",
   "Please check the asset code or address.": "Please check the asset code or address.",

extension/src/popup/locales/pt/translation.json

@@ -478,6 +478,7 @@
   "Password": "Senha",
   "Path": "Caminho",
   "Payment token logo": "Logotipo do token de pagamento",
+  "Permissionless lending pool with no admin. Collateral factors, interest curves, and supported assets are locked at deployment.": "Pool de empréstimo sem permissão e sem administrador. Fatores de garantia, curvas de juros e ativos compatíveis são fixados na implantação.",
   "Pin Freighter to the toolbar": "Fixar Freighter na toolbar",
   "Please check if the network information is correct and try again.": "Por favor, verifique se as informações da rede estão corretas e tente novamente.",
   "Please check the asset code or address.": "Por favor, verifique o código do ativo ou endereço.",