Skip to content

getTransactions should always return transactions as an array instead of null #398

Closed
@leighmcculloch

Description

@leighmcculloch

What version are you using?

22.1.2-755d81f1c738943f55ba6d61cbd72dc65de0661f

What did you do?

$ stellar container start
$ curl http://localhost:8000/rpc \
    --header 'Content-Type: application/json' \
    --data \
    jq '{"jsonrpc":"2.0","id":1,"method":"getTransactions","params":{"startLedger":1366}}'
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "transactions": null,
    "latestLedger": 1452,
    "latestLedgerCloseTimestamp": 1744155679,
    "oldestLedger": 8,
    "oldestLedgerCloseTimestamp": 1744154230,
    "cursor": "6236292513793"
  }
}

What did you expect to see?

Transactions as an empty array [].

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "transactions": [],
    "latestLedger": 1452,
    "latestLedgerCloseTimestamp": 1744155679,
    "oldestLedger": 8,
    "oldestLedgerCloseTimestamp": 1744154230,
    "cursor": "6236292513793"
  }
}

It makes coding clients simpler if the data type is consistent.

What did you see instead?

Transactions as null.

See above.

Related

Metadata

Metadata

Assignees

Labels

Type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions