Return the full `LedgerEntry` not `LedgerEntryData` in `getLedgerEntries`

[leighmcculloch]

What problem does your feature solve?

The getLedgerEntries method returns the LedgerEntryData that is a subset of the ledger entry, so it doesn't actually return all the information in a ledger entry. Information missing is sponsorship information.

What would you like to see?

The getLedgerEntries changed to returning the full LedgerEntry in a way that is safe and backwards compatible.

[leighmcculloch]

The underlying core function returns the full LedgerEntry.

[Shaptic]

This is complete as of v23

[leighmcculloch]

Confirming I'm understanding the solution. The RPC doesn't return the full LedgerEntry, it returns the LedgerEntryData and then any additional fields separately, so that a client if they want the full LedgerEntry can rebuild it?

[Shaptic]

@leighmcculloch that’s correct—this is the compromise in order to not introduce a breaking change where all clients would have to update code to decode the field.

[leighmcculloch]

👍🏻 Great call I think.