Skip to content

Commit d9e1006

Browse files
committed
storediag tuning
* time of logging * v2 sdk enhancements
1 parent 7a67591 commit d9e1006

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/main/java/org/apache/hadoop/fs/store/diag/S3ADiagnosticsInfo.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ public class S3ADiagnosticsInfo extends StoreDiagnosticsInfo {
300300
{"fs.s3a.audit.referrer.enabled", false, false},
301301
{"fs.s3a.audit.referrer.filter", false, false},
302302
{FS_S3A_AUDIT_REJECT_OUT_OF_SPAN_OPERATIONS, false, false},
303-
{"fs.s3a.audit.request.handlers", false, false},
303+
{"fs.s3a.audit.request.handlers", false, false}, // v1 sdk
304+
{"fs.s3a.audit.execution.interceptors", false, false}, // v2 sdk
304305
{"fs.s3a.audit.service.classname", false, false},
305306

306307
/* access points. */
@@ -522,7 +523,9 @@ public class S3ADiagnosticsInfo extends StoreDiagnosticsInfo {
522523
"log4j.properties",
523524
"com/amazonaws/internal/config/awssdk_config_default.json",
524525
"awssdk_config_override.json",
525-
"com/amazonaws/endpointdiscovery/endpoint-discovery.json"
526+
"com/amazonaws/endpointdiscovery/endpoint-discovery.json",
527+
"software/amazon/awssdk/global/handlers/execution.interceptors",
528+
"software/amazon/awssdk/services/s3/execution.interceptors"
526529
};
527530

528531
public static final String KEEP = "keep";

src/main/java/org/apache/hadoop/fs/store/diag/StoreDiag.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import java.nio.file.Files;
4141
import java.security.CodeSource;
4242
import java.security.NoSuchAlgorithmException;
43+
import java.time.Instant;
4344
import java.util.Collection;
4445
import java.util.Date;
4546
import java.util.Enumeration;
@@ -186,6 +187,7 @@ public int run(String[] args, PrintStream stream) throws Exception {
186187
heading("Store Diagnostics for %s on %s",
187188
UserGroupInformation.getCurrentUser(),
188189
NetUtils.getHostname());
190+
println("Collected at at %s%n", Instant.now());
189191

190192
// process the options
191193
maybeAddTokens(TOKENFILE);

0 commit comments

Comments
 (0)