HADOOP-19654. SDK upgrade

- Lots of qualifying s3 express incomplete uploads
- cloudstore listobjects working again (no tests! who knew!)

Author: steveloughran

src/main/java/org/apache/hadoop/fs/s3a/sdk/ListObjects.java

@@ -76,7 +76,7 @@ public ListObjects() {
 
   @Override
   public int run(String[] args) throws Exception {
-    List<String> paths = processArgs(args, 2, -1, USAGE);
+    List<String> paths = processArgs(args, 1, 1, USAGE);
 
     final Configuration conf = createPreconfiguredConfig();
     // stop auditing rejecting client direct calls.
@@ -106,6 +106,9 @@ public int run(String[] args) throws Exception {
       String bucket = fs.getBucket();
       final S3Client s3 = fs.getS3AInternals().getAmazonS3Client("listobjects");
       String key = S3ListingSupport.pathToKey(source);
+      if (!key.endsWith("/")) {
+        key += "/";
+      }
       ListObjectsV2Request request = S3ListingSupport.createListObjectsRequest(
           source.toUri().getHost(), key, null);
 
@@ -116,7 +119,7 @@ public int run(String[] args) throws Exception {
       List<ObjectIdentifier> objectsToDelete =
           new ArrayList<>(deletePageSize);
 
-      heading("Listing objects under %s", source);
+      heading("Listing Objects under %s", source);
       boolean finished = false;
       while (!finished && objects.hasNext()) {
         final ListObjectsV2Response page = objects.next();
@@ -168,16 +171,14 @@ public int run(String[] args) throws Exception {
       String action = delete ? "Deleted" : "Found";
       println("%s %d objects with total size %d bytes", action, objectCount, size);
       if (!prefixes.isEmpty()) {
-        println("");
         heading("%s prefixes", prefixes.size());
         for (String prefix : prefixes) {
           println(prefix);
         }
       }
       if (!markers.isEmpty()) {
-        println("");
         int markerCount = markers.size();
-        heading("marker count: %d", markerCount);
+        heading("Marker count: %d", markerCount);
         if (purge) {
           println("Purging all directory markers");
         }

src/main/java/org/apache/hadoop/fs/s3a/sdk/S3ListingSupport.java

@@ -18,9 +18,6 @@
 
 package org.apache.hadoop.fs.s3a.sdk;
 
-import java.text.DateFormat;
-import java.text.SimpleDateFormat;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import software.amazon.awssdk.services.s3.model.ListObjectVersionsRequest;
@@ -39,8 +36,6 @@ public class S3ListingSupport {
 
   private static final Logger LOG = LoggerFactory.getLogger(S3ListingSupport.class);
 
-  private static final DateFormat df = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss");
-
   public static final int MAX_KEYS = 5000;
 
   /**
@@ -134,16 +129,14 @@ public static boolean objectRepresentsDirectory(final String name,
   public static String stringify(S3Object summary) {
     return String.format("\"%s\"\tsize: [%d]\t%s\ttag: %s", summary.key(),
         summary.size(),
-        df.format(summary.lastModified()),
+        summary.lastModified().toString(),
         summary.eTag());
   }
 
   static boolean isDirMarker(final ObjectVersion summary) {
     return objectRepresentsDirectory(summary.key(), summary.size());
   }
 
-
-
   static int result(boolean b) {
     return b ? 1 : 0;
   }