replace 'avcodec_close' with 'avcodec_free_context'

christian-rauch · christian-rauch · commit 5fc306401f83 · 2025-10-08T17:48:22.000+02:00
See 'avcodec_close' docstring:

Do not use this function. Use avcodec_free_context() to destroy a
codec context (either open or closed).
diff --git a/components/pango_video/src/drivers/ffmpeg.cpp b/components/pango_video/src/drivers/ffmpeg.cpp
@@ -261,7 +261,7 @@ FfmpegVideo::~FfmpegVideo()
     av_free(pFrameOut);
     av_free(pFrame);
 
-    avcodec_close(pCodecContext);
+    avcodec_free_context(&pCodecContext);
     avformat_close_input(&pFormatCtx);
     sws_freeContext(img_convert_ctx);
 }
diff --git a/components/pango_video/src/drivers/ffmpeg_output.cpp b/components/pango_video/src/drivers/ffmpeg_output.cpp
@@ -199,7 +199,7 @@ FfmpegVideoOutputStream::~FfmpegVideoOutputStream()
     }
 
     av_free(frame);
-    avcodec_close(codec_context);
+    avcodec_free_context(&codec_context);
 }
 
 FfmpegVideoOutput::FfmpegVideoOutput(const std::string& filename, int base_frame_rate, int bit_rate, bool flip_image)

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ FfmpegVideo::~FfmpegVideo()`
`261`	`261`	`av_free(pFrameOut);`
`262`	`262`	`av_free(pFrame);`
`263`	`263`
`264`		`- avcodec_close(pCodecContext);`
	`264`	`+ avcodec_free_context(&pCodecContext);`
`265`	`265`	`avformat_close_input(&pFormatCtx);`
`266`	`266`	`sws_freeContext(img_convert_ctx);`
`267`	`267`	`}`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ FfmpegVideoOutputStream::~FfmpegVideoOutputStream()`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`av_free(frame);`
`202`		`- avcodec_close(codec_context);`
	`202`	`+ avcodec_free_context(&codec_context);`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`FfmpegVideoOutput::FfmpegVideoOutput(const std::string& filename, int base_frame_rate, int bit_rate, bool flip_image)`