Skip to content

Commit de24552

Browse files
committed
fix(gstreamer): Gate legacy SDP patches to <1.20
1 parent 4898daf commit de24552

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

publish.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7060,12 +7060,12 @@ def on_offer_created(promise, _, __):
70607060
text = text.replace("a=rtpmap:96 ulpfec/90000\r\n","a=rtpmap:97 ulpfec/90000\r\n")
70617061
text = text.replace("a=rtpmap:96 rtx/90000\r\na=fmtp:96 apt=96\r\n","")
70627062

7063-
if self.novideo and not self.noaudio: # impacts audio and video as well, but chrome / firefox seems to handle it
7063+
gst_ver = Gst.version()
7064+
if self.novideo and not self.noaudio and gst_ver.major == 1 and gst_ver.minor < 20: # impacts audio and video as well, but chrome / firefox seems to handle it
70647065
printc("Patching SDP due to Gstreamer webRTC bug - audio-only issue", "A6F") # just chrome doesn't handle this
70657066
text = replace_ssrc_and_cleanup_sdp(text)
70667067

70677068
# Fix audio SDP issues for GStreamer < 1.20 (1.18 has known SDP bugs Chrome rejects)
7068-
gst_ver = Gst.version()
70697069
if not self.noaudio and gst_ver.major == 1 and gst_ver.minor < 20:
70707070
if 'm=audio' in text:
70717071
printc("Patching audio SDP for GStreamer 1.18 compatibility", "A6F")

0 commit comments

Comments
 (0)