initial deafen not working

[PurpurTentakel97]

I'm using a directors room on a self hosted version (28.6)

My room link looks like this:
room: https://vdo.test-conf.de/?room=room&password=password&director&groupmode
cam: https://vdo.test-conf.de/?label=cam_Andi&push=b9a212ba0a4b07b94a78a2bfda713066&room=room&password=password&maxframerate=30&g=0&ssid&group=1
screen: https://vdo.test-conf.de/?label=screen_Andi&push=9dea86c5281a5fa763a251e995393c1a&room=room&password=password&maxframerate=30&g=0&ssid&group=1&deafen

I also managed to recrate the issue within the version on https://vdo.ninja (28.6)
The links here looks like this.
room: https://vdo.ninja/?director=bestTestRoom&password=test-conf&groupmode
cam: https://vdo.ninja/?room=bestTestRoom&hash=ed94&maxframerate=30&g=0&ssid&group=1&push=DQ8wqFw
screen: https://vdo.ninja/?room=bestTestRoom&hash=ed94&maxframerate=30&g=0&ssid&group=1&deafen&push=DGum9Vv

The issue is that the screen should be deafend from the beginning.
But I can hear the cam from the screen tab (when I unmuted the cam of course)
When I undeafen and deafen the screen it behaves like expected. I no longer have audio within the screen tab.

I would expect that the screen member would be deafend initially. So it seems to be an issue having to do with setting the default value for that feature, not with the feature in general.

Please correct me if I do misunderstand something here.

btw: awesome software. It is working extremely good. We're hosting an online conference on Twitch with it and we're a very happy how well this works. This had to be said.

[steveseguin]

Thank you for reporting the issue.

I looked into it. It seems to be a bug in Chrome (Chromium).

This doesn't work:

  if (receivers[i].track.kind == "audio") {
      receivers[i].track.enabled = !session.directorSpeakerMuted;
  }

This does work:

  if (receivers[i].track.kind == "audio") {
      receivers[i].track.enabled = true;
      receivers[i].track.enabled = !session.directorSpeakerMuted;
  }

So I can't disable an audio track unless it has first been explicitly enabled, which is a regression/bug in Chrome from my perspective.

A possible solution that you can implement yourself currently is to change the code around line ~34050 in the file lib.js, where you would add receivers[i].track.enabled = true; before the line receivers[i].track.enabled = !session.directorSpeakerMuted;

I've pushed this change to https://vdo.ninja/alpha/ , and will hot patch production in a bit with it. I will later push to Github once I have done some clean up of some recent feature additions. I think there might be some other areas I need to patch also, so the fix may not be complete yet, and I will include those complete fixes when I push to Github.

Regards,
Steve

[PurpurTentakel97]

I tried to reproduce the issue at https://vdo.ninja/alpha/.
It seems to be working there now.
Good work.
Thank you.