Repository navigation
V4 - #1193
Merged
Merged
V4#1193
Conversation
- apply formatting to "new" code
- add vite build script
…rom the `@simple-git/` sub-packages. - apply the `node:` schema for node specific imports - generate types with `tsc`
🦋 Changeset detectedLatest commit: 9d5f9cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ent variable to disable abbreviations in `git` commands
…ent variable to disable abbreviations in `git` commands
…ule mocks only in unit tests.
- upgrade `actions/checkout`
… and remove test asserting ability to use a default export on `simple-git`
- Remove duplication in consumer tests - Remove babel configuration, obsolete following move to vitest
- remove `console.warn` when permitting unsafe (configured through `unsafe.allowUnsafeCustomBinary`)
…er than full removal of `scripts` and `devDependencies`. - `typescript-esm-consumer` package updated to build ESM JavaScript (includes type check) then run directly with node (includes validation of exported functionality).
…unning (directly via node to avoid any inline TS transpilation by TSX) - removed obsolete block from biome config
- `simple-git` depends on current workspace version rather than `^` version of arv-parser, avoids inconsistency in vulnerability detection expectations, noting an upgrade to argv-parser will require a new release of `simple-git`.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early versions of
simple-gitwould rely solely on the caller to sanitise data, acting primarily as a tool to help create, schedule, chain and parsegittasks. As v3 introduced theunsafeplugin to detect and block potentially vulnerable task configurations, allowing a greater level of protection for callers that are not sanitising their input data, the approach to date has been to add vulnerabilities as they are identified.The v4 approach extends v3's
unsafeplugin to now reject abbreviated option names and to filter/rejectgitimpacting environment variables without explicitly opting in to this behaviour.As part of the v4 major change,
simple-gitwill also drop support for the "default" export in bothcjsandesmformats, and remove thegitPand/promiseexports that were deprecated during the v2-v3 update.