Names of generated LFRic basis functions can be too long for compiler

[tommbendall]

I've just had the following error trying to compile some new LFRic code:

  103 |       REAL(KIND=r_def), allocatable :: basis_aspc2_source_surface_altitude_on_aspc1_surface_altitude_w0_k0(:,:,:)
      |                                                                                                        1
Error: Name at (1) is too long

This is because my kernel takes the arguments source_surface_altitude (in ANY_SPACE_2) and samples it at surface_altitude_w0_k0 in (ANY_SPACE_1). The variable name above was generated for the basis function variable in the psy-layer.

Could instances like this be avoided by not appending the field variable names to the basis function variable name?

[arporter]

It's a bit difficult because the 'any-space' associated with the argument to one kernel may not be the same as the 'any-space' associated with a different argument to a different kernel (in the same invoke). I'll have a think.

[arporter]

Internally, we can keep the long names as tags in the symbol table and use abbreviated forms in the generated Fortran. I just need to locate where we actually create Symbols for the basis functions.