Skip to content

Commit a6fd531

Browse files
committed
fix: update CLAUDE.md to streamline PR checklist; enhance planner documentation on pre-claiming behavior; remove debug prints from integration tests
1 parent 455ad86 commit a6fd531

3 files changed

Lines changed: 7 additions & 17 deletions

File tree

CLAUDE.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,8 @@ git checkout -b <username>/<feature-name>
5353

5454
Never commit directly to `main`.
5555

56-
Before creating a PR, run the full check suite locally:
57-
58-
```bash
59-
cargo fmt --all
60-
cargo clippy --workspace -- -D warnings
61-
cargo test --workspace
62-
```
56+
Before creating a PR, run the full check suite locally (fmt, clippy, and test from the
57+
Commands section above).
6358

6459
## Project Status
6560

property-model/src/planner.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
//! each method are the outputs of the other methods), so selection is deterministic.
1111
//!
1212
//! **Pre-claiming**: when a determined cell eliminates all but one feasible method for a
13-
//! relationship (a method is infeasible if it would overwrite a determined cell), that
14-
//! sole method's outputs are *pre-claimed*: they can never become sources, even before all
15-
//! of the method's inputs are determined. This allows the planner to correctly handle
13+
//! relationship (a method is infeasible if it would overwrite a determined or pre-claimed
14+
//! cell), that sole method's outputs are *pre-claimed*: they can never become sources, even
15+
//! before all of the method's inputs are determined. Excluding pre-claimed outputs from
16+
//! feasibility prevents a method whose output is pre-claimed by the current flood-fill pass
17+
//! from being counted as a second viable option. This allows the planner to correctly handle
1618
//! constraints where the highest-strength cell is one of several inputs to the selected
1719
//! method.
1820
//!

property-model/tests/integration.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -195,13 +195,6 @@ fn arity_3_2_1() {
195195

196196
sheet.propagate().unwrap();
197197

198-
println!(
199-
"{}, {}, {}",
200-
sheet.read::<String>(a).unwrap(),
201-
sheet.read::<String>(b).unwrap(),
202-
sheet.read::<String>(c).unwrap()
203-
);
204-
205198
assert_eq!(sheet.read::<String>(a).unwrap(), "a");
206199
assert_eq!(sheet.read::<String>(b).unwrap(), "b");
207200
assert_eq!(sheet.read::<String>(c).unwrap(), "ab");

0 commit comments

Comments
 (0)