Skip to content

Commit c3bfbfb

Browse files
authored
use correct webpack convention (#71)
* update to new webpack convention * publish new version
1 parent eabe2ea commit c3bfbfb

File tree

10 files changed

+25
-16
lines changed

10 files changed

+25
-16
lines changed

src/packages/dev-toolkit/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/packages/dev-toolkit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dev-toolkit",
3-
"version": "7.1.0",
3+
"version": "7.1.1",
44
"description": "Universal Development Toolkit for React Veterans",
55
"main": "dev-toolkit.js",
66
"files": [

src/templates/minimal/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"dependencies": {
1313
"babel-preset-dev-toolkit": "^1.0.5",
1414
"cross-env": "^5.1.5",
15-
"dev-toolkit": "^7.1.0",
15+
"dev-toolkit": "^7.1.1",
1616
"express": "^4.16.3",
1717
"react": "^16.3.2",
1818
"react-dom": "^16.3.2"

src/templates/serverless/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"babel-preset-dev-toolkit": "^1.0.5",
1616
"clear-module": "^2.1.0",
1717
"cross-env": "^5.1.5",
18-
"dev-toolkit": "^7.1.0",
18+
"dev-toolkit": "^7.1.1",
1919
"express": "^4.16.3",
2020
"express-handlebars": "^3.0.0",
2121
"react": "^16.3.2",

src/templates/standard/dev-toolkit.config.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,15 @@ module.exports = {
44
sharedEnvs: ['MY_CUSTOM_ENV'],
55
},
66

7-
// Use custom webpack configuration here
7+
// Use custom webpack configuration here. Available `options` for each function:
8+
// { projectRoot, creatingBuild, namingConvention, assetsPath, publicPath, babelrc }
89
webpack: {
9-
loaders: function(options) {
10+
// Extend existing webpack rules (formerly called loaders)
11+
rules: function rules(options) {
1012
return [];
1113
},
12-
plugins: function(options) {
14+
// Extend existing webpack plugins
15+
plugins: function plugins(options) {
1316
return [];
1417
},
1518
},

src/templates/standard/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"babel-preset-dev-toolkit": "^1.0.5",
3737
"better-npm-run": "^0.1.0",
3838
"clear-module": "^2.1.0",
39-
"dev-toolkit": "^7.1.0",
39+
"dev-toolkit": "^7.1.1",
4040
"express": "^4.16.3",
4141
"express-handlebars": "^3.0.0",
4242
"react": "^16.3.2",

src/templates/with-eslint/dev-toolkit.config.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,15 @@ module.exports = {
44
sharedEnvs: ['MY_CUSTOM_ENV'],
55
},
66

7-
// Use custom webpack configuration here
7+
// Use custom webpack configuration here. Available `options` for each function:
8+
// { projectRoot, creatingBuild, namingConvention, assetsPath, publicPath, babelrc }
89
webpack: {
9-
loaders: function(options) {
10+
// Extend existing webpack rules (formerly called loaders)
11+
rules: function rules(options) {
1012
return [];
1113
},
12-
plugins: function(options) {
14+
// Extend existing webpack plugins
15+
plugins: function plugins(options) {
1316
return [];
1417
},
1518
},

src/templates/with-eslint/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"babel-preset-dev-toolkit": "^1.0.5",
4444
"better-npm-run": "^0.1.0",
4545
"clear-module": "^2.1.0",
46-
"dev-toolkit": "^7.1.0",
46+
"dev-toolkit": "^7.1.1",
4747
"express": "^4.16.3",
4848
"express-handlebars": "^3.0.0",
4949
"react": "^16.3.2",

src/templates/with-sass/dev-toolkit.config.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ module.exports = {
2525
cssChunkNaming: cssChunkNaming,
2626
includePaths: includePaths,
2727

28-
// Exports for dev-toolkit to pick up
28+
// Use custom webpack configuration here. Available `options` for each function:
29+
// { projectRoot, creatingBuild, namingConvention, assetsPath, publicPath, babelrc }
2930
webpack: {
30-
rules: function(options) {
31+
// Extend existing webpack rules (formerly called loaders)
32+
rules: function rules(options) {
3133
return [
3234
{
3335
test: /\.scss$/,
@@ -46,8 +48,9 @@ module.exports = {
4648
];
4749
},
4850

51+
// Extend existing webpack plugins
4952
// Generate a single css-file on build from all extracted files
50-
plugins: function(options) {
53+
plugins: function plugins(options) {
5154
const cssFileToGenerate = options.namingConvention + '.css';
5255
return options.creatingBuild
5356
? [new ExtractTextPlugin({ filename: cssFileToGenerate, allChunks: true })]

src/templates/with-sass/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"cross-env": "^5.1.5",
2020
"css-loader": "^0.28.11",
2121
"css-modules-require-hook": "^4.2.3",
22-
"dev-toolkit": "^7.1.0",
22+
"dev-toolkit": "^7.1.1",
2323
"express": "^4.16.3",
2424
"express-handlebars": "^3.0.0",
2525
"extract-text-webpack-plugin": "^4.0.0-beta.0",

0 commit comments

Comments
 (0)