fix(menubar): ignore clicks while the system menu bar is auto-hidden offscreen (#574)

When another application is running in macOS fullscreen mode and the system menu bar is auto-hidden, fast clicks at the top of the screen (before the menu bar visually reveals on hover) were hijacked by Thaw: with `Show on click` enabled the Thaw Bar popped open, and regardless of that setting the always-hidden section could be expanded offscreen. The two affected click paths in `HIDEventManager.handleShowOnClick` and `ControlItem.performAction` both lacked any visibility guard, and `NSScreen.getMenuBarHeight()` returns a cached value that keeps the existing geometry check in `isMouseInsideMenuBar` passing even when the menu bar window is no longer rendered.

This change introduces a new uncached `NSScreen.isSystemMenuBarVisible()` helper that asks the Window Server whether any menu bar status items are currently on-screen for the active space via `Bridging.getMenuBarWindowList(option: [.onScreen, .activeSpace, .itemsOnly])`, and short-circuits both click handlers when the answer is no. The items list was chosen over `WindowInfo.menuBarWindow(for:)` after empirical testing on a fullscreen repro showed the menu bar window flips to `kCGWindowIsOnscreen` at the start of the reveal animation, well before the items become visible to the user; the items list more closely tracks the perceived reveal state. No precondition on `MenuBarManager.isMenuBarHiddenBySystem` is applied because `NSApp.currentSystemPresentationOptions` is per-app and reports `0` even when another app is fullscreen, so the visibility check is both necessary and sufficient. Clicks fall through normally once the user hovers and the menu bar fully repopulates, preserving expected behaviour inside fullscreen spaces.

Fixes #481

Signed-off-by: Amir Zarrinkafsh <3339418+nightah@users.noreply.github.com>

Author: nightah

Thaw/Events/HIDEventManager.swift

@@ -741,6 +741,18 @@ extension HIDEventManager {
             return
         }
 
+        // Suppress show-on-click when no menu bar status items are currently
+        // rendered on-screen for the active space. This catches the case where
+        // a fullscreen app has auto-hidden the menu bar and the click lands in
+        // the top-of-screen trigger zone before the menu bar visually reveals.
+        // NSApp.currentSystemPresentationOptions is per-app and does not
+        // reflect another app's fullscreen state, so the items-list signal is
+        // used directly without a precondition.
+        if !screen.isSystemMenuBarVisible() {
+            Self.diagLog.debug("handleShowOnClick: suppressing, no menu bar items on-screen for active space")
+            return
+        }
+
         guard isMouseInsideEmptyMenuBarSpace(appState: appState, screen: screen) else {
             return
         }

Thaw/MenuBar/ControlItem/ControlItem.swift

@@ -557,6 +557,18 @@ final class ControlItem {
         }
         let menuBarManager = appState.menuBarManager
 
+        // Suppress phantom clicks delivered to the status item button while
+        // no menu bar items are rendered on-screen for the active space. This
+        // catches fast top-of-screen clicks during the menu bar reveal
+        // sequence under a fullscreen app, which would otherwise expand the
+        // hidden section offscreen. NSApp.currentSystemPresentationOptions is
+        // per-app and does not reflect another app's fullscreen state, so the
+        // items-list signal is used directly.
+        let screenForCheck = window?.screen ?? NSScreen.main
+        if let screen = screenForCheck, !screen.isSystemMenuBarVisible() {
+            return
+        }
+
         switch event.type {
         case .leftMouseDown:
             // Capture modifier flags from the event to ensure we have the state

Thaw/Utilities/Extensions.swift

@@ -749,6 +749,19 @@ extension NSScreen {
         return fallback
     }
 
+    /// Returns true when at least one menu bar status item is currently
+    /// rendered on-screen for the active space.
+    ///
+    /// Returns false when the menu bar is auto-hidden behind a fullscreen app
+    /// and not yet visually revealed. The menu bar window itself flips to
+    /// kCGWindowIsOnscreen at the start of the reveal sequence, well before
+    /// the status items become visible to the user; gating on the items list
+    /// more closely matches the perceived reveal state, which is what click
+    /// suppression needs.
+    func isSystemMenuBarVisible() -> Bool {
+        !Bridging.getMenuBarWindowList(option: [.onScreen, .activeSpace, .itemsOnly]).isEmpty
+    }
+
     /// Returns the raw frame of the application menu on this screen, as
     /// reported by the Accessibility API, without any notch-capping applied.
     ///