fix lint

Author: fforbeck

package-lock.json

@@ -42,7 +42,7 @@
     "@opentelemetry/sdk-trace-base": "^1.27.0",
     "@storacha/capabilities": "^1.10.0",
     "@storacha/indexing-service-client": "^2.6.6",
-    "@types/node": "^24.9.1",
+    "@types/node": "^24.10.1",
     "@ucanto/client": "^9.0.2",
     "@ucanto/core": "^10.4.5",
     "@ucanto/interface": "^11.0.1",
@@ -64,6 +64,7 @@
     "@storacha/upload-client": "^1.3.6",
     "@types/chai": "^5.0.0",
     "@types/mocha": "^10.0.9",
+    "@types/node": "^24.10.1",
     "@types/node-fetch": "^2.6.11",
     "@types/sinon": "^17.0.3",
     "@web3-storage/content-claims": "^5.2.4",

package.json

@@ -7,11 +7,11 @@ import { SpaceDID } from '@storacha/capabilities/utils'
 /**
  * Extracts a SpaceDID string from various space object formats.
  * Handles string DIDs, objects with .did() method, and Uint8Arrays.
- * 
+ *
  * @param {any} space - The space object to extract DID from
  * @returns {import('@storacha/capabilities/types').SpaceDID | undefined}
  */
-function extractSpaceDID(space) {
+function extractSpaceDID (space) {
   if (!space) return undefined
 
   try {
@@ -83,7 +83,6 @@ export function withAuthorizedSpace (handler) {
       throw new Error(`failed to locate: ${dataCid}`, { cause: locRes.error })
     }
 
-
     // Legacy behavior: Site results which have no Space attached are from
     // before we started authorizing serving content explicitly. For these, we
     // always serve the content, but only if the request has no authorization
@@ -104,7 +103,7 @@ export function withAuthorizedSpace (handler) {
     const spaces = sitesWithSpace
       .map((site) => extractSpaceDID(site.space))
       .filter((space) => space !== undefined)
-    
+
     try {
       // First space to successfully authorize is the one we'll use.
       const { space: selectedSpace, delegationProofs } = await Promise.any(
@@ -126,11 +125,11 @@ export function withAuthorizedSpace (handler) {
       // If all Spaces failed to authorize, return 404 (security through obscurity)
       if (error instanceof AggregateError) {
         // Check if all errors are authorization failures (not storage errors)
-        const isAuthFailure = error.errors.every((e) => 
-          e instanceof Unauthorized || 
+        const isAuthFailure = error.errors.every((e) =>
+          e instanceof Unauthorized ||
           (e.message && e.message.includes('not authorized to serve'))
         )
-        
+
         if (isAuthFailure) {
           if (env.DEBUG === 'true') {
             console.log(
@@ -167,9 +166,9 @@ const authorize = async (space, ctx) => {
   if (relevantDelegationsResult.error) {
     return relevantDelegationsResult
   }
-  
+
   const delegationProofs = relevantDelegationsResult.ok
-  
+
   // If no delegations found, the server is not authorized to serve this content
   if (!delegationProofs || delegationProofs.length === 0) {
     return fail('The gateway is not authorized to serve this content.')
@@ -195,7 +194,7 @@ const authorize = async (space, ctx) => {
     principal: Verifier,
     validateAuthorization: () => ok({})
   })
-  
+
   if (accessResult.error) {
     return accessResult
   }

src/middleware/withAuthorizedSpace.js

@@ -80,12 +80,12 @@ export function withEgressTracker (handler) {
               return
             }
             const serializedInvocation = archiveResult.ok
-            
+
             // Non-blocking call to queue the invocation
             ctx.waitUntil(
               env.EGRESS_QUEUE.send({
                 messageId: delegation.cid,
-                invocation: serializedInvocation, 
+                invocation: serializedInvocation,
                 timestamp: Date.now()
               })
             )

src/middleware/withEgressTracker.js

@@ -55,7 +55,7 @@ const createContext = () => {
   const egressPromise = new Promise(resolve => {
     resolveEgress = resolve
   })
-  
+
   return {
     space: SpaceDID.from(
       'did:key:z6MkknBAHEGCWvBzAi4amdH5FXEXrdKoWF1UJuvc8Psm2Mda'
@@ -66,10 +66,11 @@ const createContext = () => {
     gatewaySigner,
     gatewayIdentity,
     delegationProofs: [],
+    // @ts-ignore - Fake waitUntil to capture promisses and wait for them before making test asserts
     waitUntil: (promise) => {
       // Track the promise synchronously
-      const tracked = promise.catch(error => {
-        // Ignore errors in waitUntil
+      const tracked = promise.catch((error) => {
+        console.error('Error in waitUntil:', error)
       })
       waitUntilPromises.push(tracked)
       // @ts-expect-error - Resolve the egress promise when all tracked promises complete
@@ -79,7 +80,7 @@ const createContext = () => {
     // Wait for egress tracking to complete
     waitForEgressTracking: () => egressPromise,
     path: '',
-    searchParams: new URLSearchParams(),
+    searchParams: new URLSearchParams()
   }
 }
 
@@ -152,7 +153,6 @@ describe('withEgressTracker', async () => {
     it('should record egress for a large file', async () => {
       const ctx = createContext()
       const largeContent = new Uint8Array(100 * 1024 * 1024) // 100 MB
-      const totalBytes = largeContent.byteLength
       const mockResponse = new Response(
         new ReadableStream({
           start (controller) {
@@ -184,7 +184,6 @@ describe('withEgressTracker', async () => {
       const ctx = createContext()
       const chunk1 = new TextEncoder().encode('Hello, ')
       const chunk2 = new TextEncoder().encode('world!')
-      const totalBytes = Buffer.byteLength(chunk1) + Buffer.byteLength(chunk2)
 
       const mockResponse = new Response(
         new ReadableStream({
@@ -227,7 +226,6 @@ describe('withEgressTracker', async () => {
       const carBytes = await bucket.get(key)
       expect(carBytes).to.be.not.undefined
       expect(carBytes).to.be.instanceOf(Uint8Array)
-      const expectedTotalBytes = carBytes.byteLength
 
       // Mock a response with the CAR file content
       const mockResponse = new Response(
@@ -278,7 +276,6 @@ describe('withEgressTracker', async () => {
     it('should correctly track egress for delayed responses', async () => {
       const ctx = createContext()
       const content = new TextEncoder().encode('Delayed response content')
-      const totalBytes = Buffer.byteLength(content)
 
       const mockResponse = new Response(
         new ReadableStream({
@@ -364,8 +361,6 @@ describe('withEgressTracker', async () => {
       const ctx = createContext()
       const content1 = new TextEncoder().encode('Hello, world!')
       const content2 = new TextEncoder().encode('Goodbye, world!')
-      const totalBytes1 = Buffer.byteLength(content1)
-      const totalBytes2 = Buffer.byteLength(content2)
 
       const mockResponse1 = new Response(
         new ReadableStream({
@@ -420,7 +415,7 @@ describe('withEgressTracker', async () => {
       const queuedData1 = queueSendMock.args[0][0]
       expect(queuedData1).to.have.property('invocation')
       expect(queuedData1.invocation).to.be.instanceOf(Uint8Array)
-      
+
       const queuedData2 = queueSendMock.args[1][0]
       expect(queuedData2).to.have.property('invocation')
       expect(queuedData2.invocation).to.be.instanceOf(Uint8Array)
@@ -538,12 +533,12 @@ describe('withEgressTracker', async () => {
       const response = await handler(request, {
         ...env,
         EGRESS_QUEUE: {
-          send: sinon.stub().throws("queue error"),
-          sendBatch: sinon.stub().throws("queue error")
+          send: sinon.stub().throws('queue error'),
+          sendBatch: sinon.stub().throws('queue error')
         }
       }, ctx)
       const responseBody = await response.text()
-      // Wait a bit to ensure flush callback has run and error was caught
+      // @ts-ignore Wait a bit to ensure flush callback has run and error was caught
       await new Promise(resolve => setImmediate(resolve))
 
       expect(response.status).to.equal(200)