PB-1244 use empty string instead of null when name is not specified (#13)

Co-authored-by: Dave Cole <dave@pennyblack.io>

Author: coledave

cartridges/int_pennyblack/cartridge/scripts/pennyblack/OrderToPayloadTransformer.js

@@ -29,14 +29,19 @@ OrderToPayloadTransformer.prototype._buildCustomerData = function () {
   customer.tags = this._getCustomerGroups();
   customer.total_spent = totalSpent;
 
+  var first_name, last_name;
+
   if (this._order.defaultShipment.shippingAddress) {
-    customer.first_name = this._order.defaultShipment.shippingAddress.firstName;
-    customer.last_name = this._order.defaultShipment.shippingAddress.lastName;
+    first_name = this._order.defaultShipment.shippingAddress.firstName;
+    last_name = this._order.defaultShipment.shippingAddress.lastName;
   } else {
-    customer.first_name = this._order.billingAddress.firstName;
-    customer.last_name = this._order.billingAddress.lastName;
+    first_name = this._order.billingAddress.firstName;
+    last_name = this._order.billingAddress.lastName;
   }
 
+  customer.first_name = first_name !== null && typeof first_name === 'string' ? first_name : '';
+  customer.last_name = last_name !== null && typeof last_name === 'string' ? last_name : '';
+
   var locale = Locale.getLocale(this._order.customerLocaleID);
   var language = locale ? locale.language : null;
 

test/unit/OrderToPayloadTransformer.spec.js

@@ -246,6 +246,28 @@ describe('OrderToPayloadTransformer', function () {
         let payload = new OrderToPayloadTransformer().transform(new Order(data));
         expect('promo_codes' in payload.order).to.eq(false);
       });
+
+      it('uses empty string for name when shipping address name is null', function () {
+        let data = DataLoader('order', 'guestWithNoHistory');
+        data.defaultShipment.shippingAddress.firstName = null;
+        data.defaultShipment.shippingAddress.lastName = null;
+        let payload = new OrderToPayloadTransformer().transform(new Order(data));
+        expect(payload.customer.first_name).to.eq('');
+        expect(typeof payload.customer.first_name).to.eq('string');
+        expect(payload.customer.last_name).to.eq('');
+        expect(typeof payload.customer.last_name).to.eq('string');
+      });
+
+      it('uses empty string for name when billing address name is null', function () {
+        let data = DataLoader('order', 'guestWithNoShippingAddress');
+        data.billingAddress.firstName = null;
+        data.billingAddress.lastName = null;
+        let payload = new OrderToPayloadTransformer().transform(new Order(data));
+        expect(payload.customer.first_name).to.eq('');
+        expect(typeof payload.customer.first_name).to.eq('string');
+        expect(payload.customer.last_name).to.eq('');
+        expect(typeof payload.customer.last_name).to.eq('string');
+      });
     });
 
     describe('guest with previous orders', function () {