Improving tests for creating story

Author: roberto-butti

README.md

@@ -569,6 +569,8 @@ Now we want to upload a new image, and then create a new simple story that inclu
 use Storyblok\ManagementApi\Data\Story;
 use Storyblok\ManagementApi\ManagementApiClient;
 use Storyblok\ManagementApi\Data\StoryComponent;
+use Storyblok\ManagementApi\Endpoints\StoryApi;
+use Storyblok\ManagementApi\Endpoints\AssetApi;
 
 $client = new ManagementApiClient($storyblokPersonalAccessToken);
 
@@ -577,16 +579,16 @@ $storyApi = new StoryApi($client, $spaceId);
 $assetApi = new AssetApi($client, $spaceId);
 
 echo "UPLOADING ASSET..." . PHP_EOL;
-$response = $assetApi->upload("image.png");
-$assetCreated = $response->data();
+$assetCreated = $assetApi->upload("image.png")->data();
 echo "Asset created, ID: " . $assetCreated->id() . PHP_EOL;
 
-echo "PREPARING STORY DATA..." . PHP_EOL;
+echo "PREPARING STORY CONTENT DATA..." . PHP_EOL;
 $content = new StoryComponent("article-page");
 $content->set("title", "New Article");
 $content->set("body", "This is the content");
 $content->setAsset("image", $assetCreated);
 
+echo "INITIALIZING STORY OBJECT..." . PHP_EOL;
 $story = new Story(
     "An Article",
     "an-article-" . random_int(10000, 99999),

src/Endpoints/StoryApi.php

@@ -110,43 +110,16 @@ public function create(Story $storyData): StoryResponse
             $storyData->setContent(new StoryComponent($storyData->defaultContentType()));
         }
 
-        try {
-            $httpResponse = $this->makeHttpRequest(
-                "POST",
-                $this->buildStoriesEndpoint(),
-                [
-                    "body" => json_encode(["story" => $storyData->toArray()]),
-                ]
-            );
-
-            return new StoryResponse($httpResponse);
-
-        } catch (\Exception $exception) {
-            if ($exception instanceof StoryblokApiException) {
-
-                $this->logger->info('xxxFailed to create story', [
-                    'status_code' => $exception->getCode(),
-                    'error_message' => $exception->getMessage(),
-                    'story_name' => $storyData->name(),
-                ]);
-                throw $exception;
-            }
-
-            if ($exception instanceof ClientException) {
-                $this->logger->info($exception->getResponse()->getContent(false), [
-                    'status_code' => $exception->getCode(),
-                    'error_message' => $exception->getMessage(),
-                    'story_name' => $storyData->name(),
-                ]);
-                throw $exception;
-            }
-
-            $this->logger->error($exception->getMessage(), [
-                'error' => $exception->getMessage(),
-                'story_name' => $storyData->name(),
-            ]);
-            throw $exception;
-        }
+        $httpResponse = $this->makeHttpRequest(
+            "POST",
+            $this->buildStoriesEndpoint(),
+            [
+                "body" => json_encode(["story" => $storyData->toArray()]),
+            ]
+        );
+
+        return new StoryResponse($httpResponse);
+
     }
 
     /**

tests/Feature/StoryTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use Storyblok\ManagementApi\Data\StoryComponent;
 use Storyblok\ManagementApi\Endpoints\StoryApi;
 use Storyblok\ManagementApi\ManagementApiClient;
 use Storyblok\ManagementApi\Data\Story;
@@ -41,6 +42,31 @@
     //expect($storyblokResponse->getResponseStatusCode())->toBe(404) ;
     //expect($storyblokResponse->asJson())->toBe('["This record could not be found"]');
 });
+test('Testing Creating story with error', function (): void {
+    $responses = [
+        \mockResponse("empty-story", 401),
+    ];
+
+    $client = new MockHttpClient($responses);
+    $mapiClient = ManagementApiClient::initTest($client);
+    $storyApi = $mapiClient->storyApi("222");
+
+    $storyblokResponse = $storyApi->create(
+        new Story(
+            "aa",
+            "aa",
+            new StoryComponent("aa")
+        )
+    );
+    expect($storyblokResponse->getResponseStatusCode())->toBe(401);
+    expect(function () use ($storyblokResponse): void {
+        $storyCreated = $storyblokResponse->data();
+    })->toThrow(
+        \Exception::class,
+        'HTTP 401 returned for "https://example.com/v1/spaces/222/stories'
+    );
+
+});
 
 test('Create story encodes data correctly as JSON', function (): void {
     $expectedStoryData = [