Merge pull request #49 from storyblok/fix/tests

fix: fixing broken tests

Author: ademarCardoso

.github/workflows/unit-tests.yml

@@ -0,0 +1,22 @@
+name: 'Unit Tests Production'
+
+on:
+  pull_request:
+    branches:
+      - 'master' 
+
+jobs:
+  unit-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          cache: 'yarn'
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+      - name: Clear jest cache
+        run: yarn test:unit --clearCache
+      - name: Run unit tests
+        run: yarn test:unit --silent --ci

package.json

@@ -19,7 +19,7 @@
   "scripts": {
     "lint": "eslint src/",
     "lint:fix": "eslint src/ --fix",
-    "test": "jest --silent",
+    "test:unit": "jest --silent",
     "test:coverage": "jest --coverage"
   },
   "author": "Dominik Angerer <dominikangerer1@gmail.com>, Alexander Feiglstorfer <delooks@gmail.com>",

tests/units/delete-components.spec.js

@@ -19,6 +19,9 @@ describe('testing deleteComponents', () => {
         const id = path.split('/')[1]
         return Promise.resolve({ data: { component: components[id] } })
       }),
+      getComponents: jest.fn(() => {
+        return components
+      }),
       delete: jest.fn(() => Promise.resolve())
     }
     return deleteComponents(api, { source, reversed: false }).then(() => {
@@ -29,18 +32,16 @@ describe('testing deleteComponents', () => {
   it('api.deleteComponents reverse', () => {
     const source = 'components.js'
     const components = FAKE_COMPONENTS()
-    const spy = jest.spyOn(fs, 'readFileSync').mockReturnValue(JSON.stringify({
-      components
-    }))
+    const copy = [...components]
+    copy.splice(2, 1)
+    const spy = jest.spyOn(fs, 'readFileSync').mockReturnValue(JSON.stringify([...copy]))
     const api = {
       get: jest.fn((path) => {
         const id = path.split('/')[1]
         return Promise.resolve({ data: { component: components[id] } })
       }),
       getComponents: jest.fn(() => {
-        const copy = [...components]
-        copy.splice(3, 1)
-        return copy
+        return components
       }),
       delete: jest.fn(() => Promise.resolve())
     }

tests/units/pull-components.spec.js

@@ -40,7 +40,7 @@ describe('testing pullComponents', () => {
     }
 
     const options = {
-      compFileName: SPACE
+      fileName: SPACE
     }
 
     const expectFileName = `components.${SPACE}.json`
@@ -71,7 +71,7 @@ describe('testing pullComponents', () => {
     }
 
     const options = {
-      space: SPACE
+      fileName: SPACE
     }
 
     const expectComponentFileName = `components.${SPACE}.json`
@@ -108,7 +108,7 @@ describe('testing pullComponents', () => {
     }
 
     const options = {
-      space: SPACE,
+      fileName: SPACE,
       separateFiles: true
     }
 
@@ -117,15 +117,15 @@ describe('testing pullComponents', () => {
         expect(fs.writeFile.mock.calls.length).toBe(FAKE_COMPONENTS().length)
 
         for (const comp in FAKE_COMPONENTS()) {
-          const compFileName = `${FAKE_COMPONENTS()[comp].name}-${SPACE}.json`
+          const fileName = `${FAKE_COMPONENTS()[comp].name}-${SPACE}.json`
           let data = FAKE_COMPONENTS()[comp]
           const [compPath, compData] = fs.writeFile.mock.calls[comp]
 
           if (FAKE_COMPONENTS()[comp].name === 'logo') {
             data = { ...FAKE_COMPONENTS()[comp], component_group_name: '' }
           }
 
-          expect(compPath).toBe(`./${compFileName}`)
+          expect(compPath).toBe(`./${fileName}`)
           expect(JSON.parse(compData)).toEqual(data)
         }
       })