refactor(push): simplify space data filtering logic

Author: imranolas

package.json

@@ -44,7 +44,6 @@
     "json-schema-to-typescript": "^15.0.4",
     "minimatch": "^10.0.3",
     "ohash": "^2.0.11",
-    "p-limit": "^6.2.0",
     "pathe": "^2.0.3",
     "read-package-up": "^11.0.0",
     "storyblok-js-client": "^6.10.12"

src/commands/components/push/constants.ts

@@ -3,7 +3,9 @@ import type { CommandOptions } from '../../../types';
 export interface PushComponentsOptions extends CommandOptions {
 
   /**
-   * The regex filter to apply to the components before pushing.
+   * The glob pattern filter to apply to components before pushing.
+   * Only matching components (and their presets) will be pushed.
+   * Dependencies are assumed to exist in the target space.
    * @default `.*`
    */
   filter?: string;

src/commands/components/push/utils.ts

@@ -2,53 +2,61 @@ import type { SpaceData } from '../constants';
 import { minimatch } from 'minimatch';
 
 /**
- * Filters space data to only include a specific component and its dependencies
+ * Filters space data to only include a specific component (no dependencies)
  */
 export function filterSpaceDataByComponent(spaceData: SpaceData, componentName: string): SpaceData {
-  const filteredSpaceData: SpaceData = {
-    components: [],
-    groups: [...spaceData.groups], // Keep all groups for dependency resolution
-    internalTags: [...spaceData.internalTags], // Keep all tags for dependency resolution
-    presets: [],
-  };
-
   // Find the target component
   const targetComponent = spaceData.components.find(component => component.name === componentName);
-  if (targetComponent) {
-    filteredSpaceData.components.push(targetComponent);
-
-    // Find presets for this component
-    filteredSpaceData.presets = spaceData.presets.filter(
-      preset => preset.component_id === targetComponent.id,
-    );
+  if (!targetComponent) {
+    return {
+      components: [],
+      groups: [],
+      internalTags: [],
+      presets: [],
+    };
   }
 
-  return filteredSpaceData;
+  // Find presets for this component
+  const filteredPresets = spaceData.presets.filter(
+    preset => preset.component_id === targetComponent.id,
+  );
+
+  return {
+    components: [targetComponent],
+    groups: [], // No groups - dependencies assumed to exist in target
+    internalTags: [], // No tags - dependencies assumed to exist in target
+    presets: filteredPresets,
+  };
 }
 
 /**
- * Filters space data to only include components matching a glob pattern
+ * Filters space data to only include components matching a glob pattern (no dependencies)
  */
 export function filterSpaceDataByPattern(spaceData: SpaceData, pattern: string): SpaceData {
-  const filteredSpaceData: SpaceData = {
-    components: [],
-    groups: [...spaceData.groups], // Keep all groups for dependency resolution
-    internalTags: [...spaceData.internalTags], // Keep all tags for dependency resolution
-    presets: [],
-  };
-
   // Filter components by pattern
   const matchingComponents = spaceData.components.filter(component =>
     minimatch(component.name, pattern),
   );
 
-  filteredSpaceData.components = matchingComponents;
+  if (matchingComponents.length === 0) {
+    return {
+      components: [],
+      groups: [],
+      internalTags: [],
+      presets: [],
+    };
+  }
 
   // Find presets for matching components
   const componentIds = matchingComponents.map(component => component.id);
-  filteredSpaceData.presets = spaceData.presets.filter(
+  const filteredPresets = spaceData.presets.filter(
     preset => componentIds.includes(preset.component_id),
   );
 
-  return filteredSpaceData;
+  return {
+    components: matchingComponents,
+    groups: [], // No groups - dependencies assumed to exist in target
+    internalTags: [], // No tags - dependencies assumed to exist in target
+    presets: filteredPresets,
+  };
 }