fix: 203-v4-languages-infinite-fetching-for-space-with-no-languages-in-the-list (#204)

* fix: call spinner.failed on warning

- Added a spinner failure indication when no languages are found.
- Updated the warning message format in the konsola utility for better readability.

* chore: enable sourcemaps for debugging

* tests: update warning message format in tests

Author: alvarosabu

.vscode/launch.json

@@ -62,7 +62,7 @@
       "request": "launch",
       "name": "Debug Pull languages",
       "program": "${workspaceFolder}/dist/index.mjs",
-      "args": ["languages", "pull", "--space", "2950182323", "--path", ".storyblok"],
+      "args": ["languages", "pull", "--space", "295018"],
       "cwd": "${workspaceFolder}",
       "console": "integratedTerminal",
       "sourceMaps": true,

build.config.ts

@@ -4,4 +4,5 @@ export default defineBuildConfig({
   declaration: true,
   entries: ['./src/index'],
   failOnWarn: false,
+  sourcemap: true,
 });

src/commands/languages/index.test.ts

@@ -138,7 +138,7 @@ describe('languagesCommand', () => {
         vi.mocked(fetchLanguages).mockResolvedValue(mockResponse);
 
         await languagesCommand.parseAsync(['node', 'test', 'pull', '--space', '24568']);
-        expect(konsola.warn).toHaveBeenCalledWith(`No languages found in the space 24568`);
+        expect(konsola.warn).toHaveBeenCalledWith(`No languages found in the space 24568`, true);
       });
     });
 

src/commands/languages/index.ts

@@ -52,7 +52,10 @@ languagesCommand
       const internationalization = await fetchLanguages(space, state.password, state.region);
 
       if (!internationalization || internationalization.languages?.length === 0) {
-        konsola.warn(`No languages found in the space ${space}`);
+        spinner.failed();
+
+        konsola.warn(`No languages found in the space ${space}`, true);
+        konsola.br();
         return;
       }
       await saveLanguagesToFile(space, internationalization, {

src/utils/konsola.test.ts

@@ -16,7 +16,7 @@ describe('konsola', () => {
       const consoleSpy = vi.spyOn(console, 'warn');
       konsola.warn('This is a test warning message');
 
-      expect(consoleSpy).toHaveBeenCalledWith(`${chalk.yellow('⚠️')} This is a test warning message`);
+      expect(consoleSpy).toHaveBeenCalledWith(`${chalk.yellow('⚠️ ')} This is a test warning message`);
     });
 
     it('should prompt a warning message with header', () => {

src/utils/konsola.ts

@@ -54,7 +54,7 @@ export const konsola = {
       console.warn(formatHeader(warnHeader));
     }
 
-    console.warn(message ? `${chalk.yellow('⚠️')} ${message}` : '');
+    console.warn(message ? `${chalk.yellow('⚠️ ')} ${message}` : '');
   },
   error: (message: string, info?: unknown, options?: KonsolaFormatOptions) => {
     if (options?.header) {

tsconfig.json

@@ -13,7 +13,10 @@
     "noFallthroughCasesInSwitch": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
+    "inlineSourceMap": false,
     "noEmit": true,
+    /* Debugging */
+    "sourceMap": true,
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
     "isolatedModules": true,