Skip to content

Allow ISbLinksParams to StoryblokClient.getAll method #944

@shabab477

Description

@shabab477

StoryblokClient#getAll method supports params for ISbStoryData, ISbMultipleStoriesData, ISbAssetsParams but not params for ISbLinksParams. This is a big problem because for creating sitemaps with lastmod elements.


Expected Behavior

await storyBlokClient.getAll('cdn/links', {
      starts_with: 'some-path',
      version: 'published',
      resolve_links: 'link',
      include_dates: 1 // this should not throw TS error
    });

Current Behavior

await storyBlokClient.getAll('cdn/links', {
      starts_with: 'some-path',
      version: 'published',
      resolve_links: 'link',
      include_dates: 1 // this throws TS error
    });

Steps to Reproduce

See current behavior

Note:

  1. The get method is overloaded correctly.
  2. Would expect the same for getAll method.
  3. At the very least allow include_dates to be allowed.

Metadata

Metadata

Assignees

Labels

feature[Issue] New feature or requestv7

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions