Skip to content

Commit 314af88

Browse files
committed
remove description arg from evals
1 parent b80922d commit 314af88

7 files changed

Lines changed: 9 additions & 45 deletions

File tree

eval/README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,14 @@ node eval.ts --agent claude-code --context components.json --upload 100-flight-b
2727

2828
## CLI Options
2929

30-
| Option | Short | Type | Description |
31-
| --------------- | ----- | ------- | ---------------------------------------------------------------------------------------- |
32-
| `--agent` | `-a` | string | Which agent to use (`claude-code`) |
33-
| `--context` | `-c` | string | Context type: `false`, `*.json` (manifest), `mcp.config.json`, or `*.md` (extra prompts) |
34-
| `--verbose` | `-v` | boolean | Show detailed logs during execution |
35-
| `--description` | `-d` | string | Optional description for this experiment run |
36-
| `--storybook` | `-s` | boolean | Auto-start Storybook after completion |
37-
| `--upload` | `-u` | boolean | Upload results to Google Sheets (default: true) |
38-
| `--help` | `-h` | - | Display help information |
30+
| Option | Short | Type | Description |
31+
| ------------- | ----- | ------- | ---------------------------------------------------------------------------------------- |
32+
| `--agent` | `-a` | string | Which agent to use (`claude-code`) |
33+
| `--context` | `-c` | string | Context type: `false`, `*.json` (manifest), `mcp.config.json`, or `*.md` (extra prompts) |
34+
| `--verbose` | `-v` | boolean | Show detailed logs during execution |
35+
| `--storybook` | `-s` | boolean | Auto-start Storybook after completion |
36+
| `--upload` | `-u` | boolean | Upload results to Google Sheets (default: true) |
37+
| `--help` | `-h` | - | Display help information |
3938

4039
**Positional argument:** The eval directory name (e.g., `100-flight-booking-plain`)
4140

eval/eval.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ const experimentArgs: ExperimentArgs = {
7171
projectPath,
7272
resultsPath,
7373
verbose: args.verbose,
74-
description: args.description,
7574
upload: args.upload,
7675
evalName: args.eval,
7776
context: args.context,

eval/lib/collect-args.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export async function collectArgs() {
1717
agent: { type: 'string', short: 'a' },
1818
verbose: { type: 'boolean', default: false, short: 'v' },
1919
storybook: { type: 'boolean', short: 's' },
20-
description: { type: 'string', short: 'd' },
2120
context: { type: 'string', short: 'c' },
2221
upload: { type: 'boolean', short: 'u' },
2322
},
@@ -45,7 +44,6 @@ export async function collectArgs() {
4544
v.union([v.literal('claude-code'), v.literal('copilot')]),
4645
),
4746
verbose: v.boolean(),
48-
description: v.optional(v.string()),
4947
storybook: v.optional(v.boolean()),
5048
upload: v.optional(v.boolean()),
5149
context: v.optionalAsync(
@@ -162,29 +160,6 @@ export async function collectArgs() {
162160
rerunCommandParts.push('--agent', result.toString());
163161
return result;
164162
},
165-
description: async function (): Promise<string | undefined> {
166-
if (parsedArgValues.description !== undefined) {
167-
rerunCommandParts.push(
168-
'--description',
169-
`"${parsedArgValues.description}"`,
170-
);
171-
return parsedArgValues.description;
172-
}
173-
174-
const result = await p.text({
175-
message:
176-
'Can you provide a short description for this specific experiment?',
177-
placeholder:
178-
'This description is optional and can help provide context for the experiment results.',
179-
});
180-
if (p.isCancel(result)) {
181-
p.cancel('Operation cancelled.');
182-
process.exit(0);
183-
}
184-
185-
rerunCommandParts.push('--description', `"${result}"`);
186-
return result;
187-
},
188163
context: async function (): Promise<Context> {
189164
const evalPath = path.resolve(path.join('evals', evalPromptResult));
190165

@@ -473,7 +448,6 @@ export async function collectArgs() {
473448
const result = {
474449
agent: promptResults.agent,
475450
verbose: promptResults.verbose,
476-
description: promptResults.description,
477451
eval: evalPromptResult,
478452
context: promptResults.context,
479453
storybook: parsedArgValues.storybook,

eval/lib/save/environment.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { x } from 'tinyexec';
66

77
export async function saveEnvironment({
88
resultsPath,
9-
description,
109
agent,
1110
}: ExperimentArgs) {
1211
const info = JSON.parse(
@@ -34,7 +33,6 @@ export async function saveEnvironment({
3433
{
3534
agent,
3635
date: new Date().toISOString(),
37-
description,
3836
branch,
3937
commit,
4038
...info,

eval/lib/save/google-sheet.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const GOOGLE_SHEETS_URL =
1313
type SheetsData = {
1414
timestamp: string;
1515
evalName: string;
16-
description: string;
1716
chromaticUrl: string;
1817
buildSuccess: boolean;
1918
typeCheckErrors: number;
@@ -61,12 +60,11 @@ export async function saveToGoogleSheets(
6160
environment: { branch: string; commit: string },
6261
chromaticUrl?: string,
6362
): Promise<void> {
64-
const { experimentPath, description, evalName, context } = experimentArgs;
63+
const { experimentPath, evalName, context } = experimentArgs;
6564

6665
const data: SheetsData = {
6766
timestamp: new Date().toISOString().replace('Z', ''),
6867
evalName,
69-
description: description || '',
7068
chromaticUrl: chromaticUrl || '',
7169
buildSuccess: evaluationSummary.buildSuccess,
7270
typeCheckErrors: evaluationSummary.typeCheckErrors,

eval/lib/show-help.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ export function showHelp(): void {
5858
console.log(
5959
`\n ${styleText('yellow', '-v, --verbose')} Show detailed logs during execution (default: false)`,
6060
);
61-
console.log(
62-
`\n ${styleText('yellow', '-d, --description <text>')} Optional description for this experiment run`,
63-
);
6461
console.log(
6562
`\n ${styleText('yellow', '-s, --storybook')} Auto-start Storybook after evaluation completes`,
6663
);

eval/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export type ExperimentArgs = {
88
projectPath: string;
99
resultsPath: string;
1010
verbose: boolean;
11-
description?: string;
1211
hooks: Hooks;
1312
upload: boolean;
1413
evalName: string;

0 commit comments

Comments
 (0)