Do not include get-changed-stories instructions when changeDetection is disabled

Author: ghengeveld

packages/addon-mcp/src/instructions/storybook-story-instructions.md

@@ -146,7 +146,7 @@ play: async ({ canvas }) => {
 ## Story Linking Agent Behavior
 
 - ALWAYS provide story links after any changes to stories files, including changes to existing stories.
-- After changing UI, call `{{GET_CHANGED_STORIES_TOOL_NAME}}` first, then use `{{PREVIEW_STORIES_TOOL_NAME}}` with selected `storyId` values from those results.
+- {{STORY_LINKING_WORKFLOW}}
 - When sharing links, choose the most relevant subset for the user and avoid long lists (generally no more than 5 links).
-- If you do not share all changed story links, include this Storybook fallback link so the user can view the complete changed list: `/?statuses=affected;modified;new`.
+- {{CHANGED_STORY_FALLBACK_LINK_GUIDANCE}}
 - After changing any UI components, ALWAYS search for related stories that might cover the changes you've made. If you find any, provide the story links to the user. THIS IS VERY IMPORTANT, as it allows the user to visually inspect the changes you've made. Even later in a session when changing UI components or stories that have already been linked to previously, YOU MUST PROVIDE THE LINKS AGAIN.

packages/addon-mcp/src/tools/get-storybook-story-instructions.test.ts

@@ -4,7 +4,11 @@ import { ValibotJsonSchemaAdapter } from '@tmcp/adapter-valibot';
 import { getAddonVitestConstants } from './run-story-tests.ts';
 import { addGetUIBuildingInstructionsTool } from './get-storybook-story-instructions.ts';
 import type { AddonContext } from '../types.ts';
-import { PREVIEW_STORIES_TOOL_NAME, GET_UI_BUILDING_INSTRUCTIONS_TOOL_NAME } from './tool-names.ts';
+import {
+	PREVIEW_STORIES_TOOL_NAME,
+	GET_CHANGED_STORIES_TOOL_NAME,
+	GET_UI_BUILDING_INSTRUCTIONS_TOOL_NAME,
+} from './tool-names.ts';
 
 vi.mock('./run-story-tests.ts', () => ({
 	getAddonVitestConstants: vi.fn(),
@@ -157,7 +161,11 @@ describe('getUIBuildingInstructionsTool', () => {
 	it('should return UI building instructions with framework placeholders replaced', async () => {
 		const mockOptions = {
 			presets: {
-				apply: vi.fn().mockResolvedValue('@storybook/react-vite'),
+				apply: vi.fn(async (presetName: string) => {
+					if (presetName === 'framework') return '@storybook/react-vite';
+					if (presetName === 'features') return { changeDetection: true };
+					return undefined;
+				}),
 			},
 		};
 
@@ -188,13 +196,56 @@ describe('getUIBuildingInstructionsTool', () => {
 		expect(instructions).toContain('@storybook/react-vite');
 		expect(instructions).toContain('@storybook/react');
 		expect(instructions).toContain(PREVIEW_STORIES_TOOL_NAME);
+		expect(instructions).toContain(GET_CHANGED_STORIES_TOOL_NAME);
 
 		// Check that no placeholders remain
 		expect(instructions).not.toContain('{{FRAMEWORK}}');
 		expect(instructions).not.toContain('{{RENDERER}}');
 		expect(instructions).not.toContain('{{PREVIEW_STORIES_TOOL_NAME}}');
 	});
 
+	it('should not mention changed stories workflow when change detection is disabled', async () => {
+		const mockOptions = {
+			presets: {
+				apply: vi.fn(async (presetName: string) => {
+					if (presetName === 'framework') {
+						return '@storybook/react-vite';
+					}
+					if (presetName === 'features') {
+						return { changeDetection: false };
+					}
+					return undefined;
+				}),
+			},
+		};
+
+		const testContext: AddonContext = {
+			origin: 'http://localhost:6006',
+			options: mockOptions as any,
+			disableTelemetry: true,
+		};
+
+		const request = {
+			jsonrpc: '2.0' as const,
+			id: 1,
+			method: 'tools/call',
+			params: {
+				name: GET_UI_BUILDING_INSTRUCTIONS_TOOL_NAME,
+				arguments: {},
+			},
+		};
+
+		const response = await server.receive(request, {
+			sessionId: 'test-session',
+			custom: testContext,
+		});
+
+		const instructions = response.result?.content[0].text as string;
+
+		expect(instructions).toContain(PREVIEW_STORIES_TOOL_NAME);
+		expect(instructions).not.toContain(GET_CHANGED_STORIES_TOOL_NAME);
+	});
+
 	it('should handle Vue framework', async () => {
 		const mockOptions = {
 			presets: {

packages/addon-mcp/src/tools/get-storybook-story-instructions.ts

@@ -77,15 +77,23 @@ Even if you're familiar with Storybook, call this tool to ensure you're followin
 				}
 
 				const frameworkPreset = await options.presets.apply('framework');
+				const featuresPreset = await options.presets.apply('features', {});
+				const changeDetectionEnabled = featuresPreset?.changeDetection ?? false;
 				const framework =
 					typeof frameworkPreset === 'string' ? frameworkPreset : frameworkPreset?.name;
 				const renderer = frameworkToRendererMap[framework!];
+				const storyLinkingWorkflow = changeDetectionEnabled
+					? `After changing UI, call \`${GET_CHANGED_STORIES_TOOL_NAME}\` first, then use \`${PREVIEW_STORIES_TOOL_NAME}\` with selected \`storyId\` values from those results.`
+					: `After changing UI, call \`${PREVIEW_STORIES_TOOL_NAME}\` and share the most relevant links for the changes.`;
+				const changedStoryFallbackLinkGuidance = changeDetectionEnabled
+					? `If you do not share all changed story links, include this Storybook fallback link so the user can view the complete changed list: \`/?statuses=affected;modified;new\`.`
+					: `When linking only a subset of stories, mention that additional relevant stories may exist in Storybook.`;
 
 				let uiInstructions = storyInstructionsTemplate
 					.replace('{{FRAMEWORK}}', framework)
 					.replace('{{RENDERER}}', renderer ?? framework)
-					.replace('{{PREVIEW_STORIES_TOOL_NAME}}', PREVIEW_STORIES_TOOL_NAME)
-					.replace('{{GET_CHANGED_STORIES_TOOL_NAME}}', GET_CHANGED_STORIES_TOOL_NAME);
+					.replace('{{STORY_LINKING_WORKFLOW}}', storyLinkingWorkflow)
+					.replace('{{CHANGED_STORY_FALLBACK_LINK_GUIDANCE}}', changedStoryFallbackLinkGuidance);
 
 				// Conditionally append story testing instructions if test toolset is enabled and addon-vitest is available
 				const testToolsetAvailable =