Skip to content

Commit 1efd1ce

Browse files
authored
fix: address audit errors and use expo dev client (#886)
* fix: address audit errors and use expo dev client * changeset
1 parent 5e10b7f commit 1efd1ce

12 files changed

Lines changed: 797 additions & 873 deletions

File tree

.changeset/hot-wings-brake.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
'@storybook/addon-ondevice-actions': patch
3+
'@storybook/addon-ondevice-backgrounds': patch
4+
'@storybook/addon-ondevice-controls': patch
5+
'@storybook/addon-ondevice-notes': patch
6+
'@storybook/react-native': patch
7+
'@storybook/react-native-theming': patch
8+
'@storybook/react-native-ui': patch
9+
'@storybook/react-native-ui-common': patch
10+
'@storybook/react-native-ui-lite': patch
11+
---
12+
13+
apply npm audit fixes

.github/workflows/publish.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ jobs:
6969
env:
7070
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7171

72+
- name: Update lockfile (next)
73+
if: inputs.release_type == 'next'
74+
run: pnpm install --no-frozen-lockfile
75+
7276
- name: Publish (next)
7377
if: inputs.release_type == 'next'
7478
run: pnpm changeset publish
@@ -108,6 +112,10 @@ jobs:
108112
env:
109113
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
110114

115+
- name: Update lockfile (latest)
116+
if: inputs.release_type == 'latest'
117+
run: pnpm install --no-frozen-lockfile
118+
111119
- name: Publish (latest)
112120
if: inputs.release_type == 'latest'
113121
run: pnpm changeset publish --tag latest

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,5 @@ examples/expo-example/.maestro/output/*
3636

3737
examples/expo-example/components/PerfTesting/*.stories.tsx
3838
examples/expo-example/.certs/
39-
examples/expo-example/android
40-
examples/expo-example/ios
39+
examples/**/android
40+
examples/**/ios
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"dependencies": "2db65b8ae948675d3e3ad862f5e130503e69f47b",
3+
"devDependencies": "f734d48b191d4a8111b07cda4e48396fbcdc84df"
4+
}

examples/expo-new-wrapper-example/.rnstorybook/index.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
// and ../README.md for the full picture.
55
import AsyncStorage from '@react-native-async-storage/async-storage';
66
import { registerRootComponent } from 'expo';
7+
import { LiteUI } from '@storybook/react-native-ui-lite';
78

89
import { view } from './storybook.requires';
910

@@ -14,6 +15,7 @@ const StorybookUIRoot = view.getStorybookUI({
1415
setItem: AsyncStorage.setItem,
1516
},
1617
enableWebsockets: true,
18+
CustomUIComponent: LiteUI,
1719
});
1820

1921
registerRootComponent(StorybookUIRoot);

examples/expo-new-wrapper-example/package.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@
44
"private": true,
55
"main": "index.js",
66
"scripts": {
7-
"start": "expo start",
8-
"ios": "expo start --ios",
9-
"android": "expo start --android",
10-
"storybook:ios": "STORYBOOK_ENABLED=true expo start --ios",
11-
"storybook": "STORYBOOK_ENABLED=true expo start",
12-
"storybook:android": "STORYBOOK_ENABLED=true expo start --android",
13-
"check:types": "tsc --noEmit"
7+
"start": "expo start --dev-client",
8+
"ios": "expo run:ios",
9+
"android": "expo run:android",
10+
"storybook": "STORYBOOK_ENABLED=true expo start --dev-client",
11+
"storybook:ios": "STORYBOOK_ENABLED=true expo run:ios",
12+
"storybook:android": "STORYBOOK_ENABLED=true expo run:android",
13+
"check:types": "tsc --noEmit",
14+
"prebuild": "expo prebuild"
1415
},
1516
"dependencies": {
1617
"@expo/metro-runtime": "~56.0.5",

examples/expo-router-example/.rnstorybook/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
// `withStorybook` swaps the resolver from the project's `index.js` to this
33
// file, so it must register a root component itself. See ../metro.config.js
44
// and ../README.md for the full picture.
5-
import AsyncStorage from '@react-native-async-storage/async-storage';
5+
import Storage from 'expo-sqlite/kv-store';
66
import { registerRootComponent } from 'expo';
77
import { LiteUI } from '@storybook/react-native-ui-lite';
88
import { view } from './storybook.requires';
99

1010
const StorybookUIRoot = view.getStorybookUI({
1111
shouldPersistSelection: true,
1212
storage: {
13-
getItem: AsyncStorage.getItem,
14-
setItem: AsyncStorage.setItem,
13+
getItem: (s) => Storage.getItem(s),
14+
setItem: (s, v) => Storage.setItem(s, v),
1515
},
1616
enableWebsockets: true,
1717
CustomUIComponent: LiteUI,

examples/expo-router-example/app.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"userInterfaceStyle": "automatic",
1010
"newArchEnabled": true,
1111
"ios": {
12-
"supportsTablet": true
12+
"supportsTablet": true,
13+
"bundleIdentifier": "com.dannyhw.exporouterexample"
1314
},
1415
"android": {
1516
"adaptiveIcon": {
@@ -19,7 +20,8 @@
1920
"monochromeImage": "./assets/images/android-icon-monochrome.png"
2021
},
2122
"edgeToEdgeEnabled": true,
22-
"predictiveBackGestureEnabled": false
23+
"predictiveBackGestureEnabled": false,
24+
"package": "com.dannyhw.exporouterexample"
2325
},
2426
"web": {
2527
"output": "static",
@@ -41,7 +43,8 @@
4143
],
4244
"expo-image",
4345
"expo-web-browser",
44-
"expo-font"
46+
"expo-font",
47+
"expo-sqlite"
4548
],
4649
"experiments": {
4750
"typedRoutes": true,

examples/expo-router-example/package.json

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,16 @@
33
"main": "expo-router/entry",
44
"version": "1.0.0",
55
"scripts": {
6-
"start": "expo start",
6+
"start": "expo start --dev-client",
77
"reset-project": "node ./scripts/reset-project.js",
8-
"android": "expo start --android",
9-
"ios": "expo start --ios",
8+
"android": "expo run:android",
9+
"ios": "expo run:ios",
1010
"web": "expo start --web",
1111
"lint": "expo lint",
12-
"storybook": "STORYBOOK_ENABLED=true expo start"
12+
"storybook": "STORYBOOK_ENABLED=true expo start --dev-client",
13+
"storybook:ios": "STORYBOOK_ENABLED=true expo run:ios",
14+
"storybook:android": "STORYBOOK_ENABLED=true expo run:android",
15+
"prebuild": "expo prebuild"
1316
},
1417
"dependencies": {
1518
"@expo/vector-icons": "^15.0.3",
@@ -33,6 +36,7 @@
3336
"expo-linking": "~56.0.4",
3437
"expo-router": "~56.1.1",
3538
"expo-splash-screen": "~56.0.4",
39+
"expo-sqlite": "~56.0.3",
3640
"expo-status-bar": "~56.0.4",
3741
"expo-symbols": "~56.0.5",
3842
"expo-system-ui": "~56.0.4",
@@ -44,6 +48,7 @@
4448
"react-native-reanimated": "~4.3.0",
4549
"react-native-safe-area-context": "^5.7.0",
4650
"react-native-screens": "4.25.0-beta.3",
51+
"react-native-svg": "15.15.4",
4752
"react-native-web": "^0.21.2",
4853
"react-native-worklets": "0.8.3",
4954
"storybook": "^10.3.2",

package.json

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,6 @@
6060
"engines": {
6161
"node": ">=26.0.0"
6262
},
63-
"pnpm": {
64-
"overrides": {
65-
"@types/markdown-it": "^14.0.1",
66-
"jest-environment-jsdom>jsdom": "26.1.0",
67-
"lodash": "^4.18.1",
68-
"markdown-it": "^14.0.0",
69-
"minimatch@3": "~3.1.3",
70-
"react-docgen-typescript": "2.2.2",
71-
"serialize-javascript": ">=7.0.3",
72-
"svgo": "3.3.3",
73-
"webpack-dev-server": "^5.2.2",
74-
"zod-validation-error": "^4.0.0"
75-
}
76-
},
7763
"collective": {
7864
"type": "opencollective",
7965
"url": "https://opencollective.com/storybook"

0 commit comments

Comments
 (0)