Skip to content

Commit 2a75bc0

Browse files
authored
Merge pull request #34742 from storybookjs/norbert/dynamic-appname-rn
ReactNative: AppRegistry component name in template
2 parents a835ed3 + 95d2f7e commit 2a75bc0

3 files changed

Lines changed: 21 additions & 5 deletions

File tree

code/lib/create-storybook/src/generators/REACT_NATIVE/generateEntrypoint.test.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ describe('generateReactNativeEntrypoint', () => {
3434
expect(output).toMatchInlineSnapshot(`
3535
"import { AppRegistry } from 'react-native';
3636
import AsyncStorage from '@react-native-async-storage/async-storage';
37+
import { LiteUI } from '@storybook/react-native-ui-lite';
3738
3839
import { view } from './storybook.requires';
40+
import { name as appName } from '../app.json';
3941
4042
/**
4143
* This file is user-editable.
@@ -49,9 +51,10 @@ describe('generateReactNativeEntrypoint', () => {
4951
getItem: AsyncStorage.getItem,
5052
setItem: AsyncStorage.setItem,
5153
},
54+
CustomUIComponent: LiteUI,
5255
});
5356
54-
AppRegistry.registerComponent('main', () => StorybookUIRoot);
57+
AppRegistry.registerComponent(appName, () => StorybookUIRoot);
5558
5659
export default StorybookUIRoot;
5760
"
@@ -78,8 +81,10 @@ describe('generateReactNativeEntrypoint', () => {
7881
expect(output).toMatchInlineSnapshot(`
7982
"import { AppRegistry } from 'react-native';
8083
import AsyncStorage from '@react-native-async-storage/async-storage';
84+
import { LiteUI } from '@storybook/react-native-ui-lite';
8185
8286
import { view } from './storybook.requires';
87+
import { name as appName } from '../app.json';
8388
8489
/**
8590
* This file is user-editable.
@@ -93,9 +98,10 @@ describe('generateReactNativeEntrypoint', () => {
9398
getItem: AsyncStorage.getItem,
9499
setItem: AsyncStorage.setItem,
95100
},
101+
CustomUIComponent: LiteUI,
96102
});
97103
98-
AppRegistry.registerComponent('main', () => StorybookUIRoot);
104+
AppRegistry.registerComponent(appName, () => StorybookUIRoot);
99105
100106
export default StorybookUIRoot;
101107
"
@@ -165,8 +171,10 @@ describe('generateReactNativeEntrypoint', () => {
165171
expect(output).toMatchInlineSnapshot(`
166172
"import { AppRegistry } from 'react-native';
167173
import AsyncStorage from '@react-native-async-storage/async-storage';
174+
import { LiteUI } from '@storybook/react-native-ui-lite';
168175
169176
import { view } from './storybook.requires';
177+
import { name as appName } from '../app.json';
170178
171179
/**
172180
* This file is user-editable.
@@ -180,9 +188,10 @@ describe('generateReactNativeEntrypoint', () => {
180188
getItem: AsyncStorage.getItem,
181189
setItem: AsyncStorage.setItem,
182190
},
191+
CustomUIComponent: LiteUI,
183192
});
184193
185-
AppRegistry.registerComponent('main', () => StorybookUIRoot);
194+
AppRegistry.registerComponent(appName, () => StorybookUIRoot);
186195
187196
export default StorybookUIRoot;
188197
"
@@ -216,8 +225,10 @@ describe('generateReactNativeEntrypoint', () => {
216225
expect(generated).toMatchInlineSnapshot(`
217226
"import { AppRegistry } from 'react-native';
218227
import AsyncStorage from '@react-native-async-storage/async-storage';
228+
import { LiteUI } from '@storybook/react-native-ui-lite';
219229
220230
import { view } from './storybook.requires';
231+
import { name as appName } from '../app.json';
221232
222233
/**
223234
* This file is user-editable.
@@ -231,9 +242,10 @@ describe('generateReactNativeEntrypoint', () => {
231242
getItem: AsyncStorage.getItem,
232243
setItem: AsyncStorage.setItem,
233244
},
245+
CustomUIComponent: LiteUI,
234246
});
235247
236-
AppRegistry.registerComponent('main', () => StorybookUIRoot);
248+
AppRegistry.registerComponent(appName, () => StorybookUIRoot);
237249
238250
export default StorybookUIRoot;
239251
"

code/lib/create-storybook/src/generators/REACT_NATIVE/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ export default defineGeneratorModule({
7373
'@storybook/addon-ondevice-controls',
7474
'@storybook/addon-ondevice-actions',
7575
'@storybook/react-native',
76+
'@storybook/react-native-ui-lite',
7677
'storybook',
7778
];
7879

code/lib/create-storybook/templates/react-native/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import { AppRegistry } from 'react-native';
22
import AsyncStorage from '@react-native-async-storage/async-storage';
3+
import { LiteUI } from '@storybook/react-native-ui-lite';
34

45
import { view } from './storybook.requires';
6+
import { name as appName } from '../app.json';
57

68
/**
79
* This file is user-editable.
@@ -15,8 +17,9 @@ const StorybookUIRoot = view.getStorybookUI({
1517
getItem: AsyncStorage.getItem,
1618
setItem: AsyncStorage.setItem,
1719
},
20+
CustomUIComponent: LiteUI,
1821
});
1922

20-
AppRegistry.registerComponent('main', () => StorybookUIRoot);
23+
AppRegistry.registerComponent(appName, () => StorybookUIRoot);
2124

2225
export default StorybookUIRoot;

0 commit comments

Comments
 (0)