Skip to content

Commit 2dcf9dc

Browse files
authored
Merge pull request #31069 from storybookjs/jeppe/improve-vitest-restarts
Addon-vitest: Correctly set coverage when restarting Vitest due to config change
2 parents 62303e7 + 71a080b commit 2dcf9dc

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Diff for: code/addons/vitest/src/node/vitest-manager.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class VitestManager {
5353

5454
constructor(private testManager: TestManager) {}
5555

56-
async startVitest({ coverage = false } = {}) {
56+
async startVitest({ coverage }: { coverage: boolean }) {
5757
const { createVitest } = await import('vitest/node');
5858

5959
const storybookCoverageReporter: [string, StorybookCoverageReporterOptions] = [
@@ -206,7 +206,6 @@ export class VitestManager {
206206
if (!this.vitest) {
207207
await this.startVitest({ coverage: coverageShouldBeEnabled });
208208
} else if (currentCoverage !== coverageShouldBeEnabled) {
209-
await this.vitestRestartPromise;
210209
await this.restartVitest({ coverage: coverageShouldBeEnabled });
211210
} else {
212211
await this.vitestRestartPromise;
@@ -391,8 +390,8 @@ export class VitestManager {
391390
const isConfig = file === this.vitest?.vite?.config.configFile;
392391
if (isConfig) {
393392
log('Restarting Vitest due to config change');
394-
await this.closeVitest();
395-
await this.startVitest();
393+
const { watching, config } = this.testManager.store.getState();
394+
await this.restartVitest({ coverage: config.coverage && !watching });
396395
}
397396
});
398397
}

0 commit comments

Comments
 (0)