Merge pull request #540 from storyprotocol/feat/bp/workflows-improvements

Test Workflow Improvements

Author: bpolania

.github/workflows/pr-external.yaml

@@ -22,7 +22,7 @@ jobs:
     needs: [authorize]
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-timestamp.yml@main
 
-  pr_build_and_test:
+  unit_tests:
     needs: [authorize, Timestamp_PR_APPROVED]
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-unit-test-workflow.yml@main
     with:
@@ -32,8 +32,8 @@ jobs:
       WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
       TEST_WALLET_ADDRESS: ${{ secrets.TEST_WALLET_ADDRESS }}
 
-  push_build_and_test:
-    needs: [pr_build_and_test]
+  integration_tests:
+    needs: [unit_tests]
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-integration-test-workflow.yml@main
     with:
       sha: ${{ github.event.pull_request.head.sha }}

.github/workflows/pr-internal.yml

@@ -13,22 +13,22 @@ jobs:
     if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-timestamp.yml@main
 
-  pr_build_and_test:
-    if: github.event_name == 'pull_request'
+  unit_tests:
     needs: [Timestamp]
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-unit-test-workflow.yml@main
     with:
-      sha: ${{ github.event.pull_request.head.sha }}
+      sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
       ENVIRONMENT: "odyssey"
     secrets:
       WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}
       TEST_WALLET_ADDRESS: ${{ secrets.TEST_WALLET_ADDRESS }}
 
-  push_build_and_test:
-    if: github.event_name == 'push'
+  integration_tests:
+    if: github.event_name == 'pull_request'
+    needs: [Timestamp]
     uses: storyprotocol/gha-workflows/.github/workflows/reusable-build-integration-test-workflow.yml@main
     with:
-      sha: ${{ github.sha }}
+      sha: ${{ github.event.pull_request.head.sha }}
       ENVIRONMENT: "odyssey"
     secrets:
       WALLET_PRIVATE_KEY: ${{ secrets.WALLET_PRIVATE_KEY }}

.github/workflows/publish-package.yaml

@@ -119,15 +119,17 @@ jobs:
           npm publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-
+  
   send_slack_notif-core-sdk:
-    needs: [print_version_to_publish]
-    uses: storyprotocol/gha-workflows/.github/workflows/reusable-slack-notifs.yml@main
-    with:
-      short-desc: "${{ github.repository }}: @story-protocol/core-sdk package has been published to NPM Registry, version: ${{ needs.print_version_to_publish.outputs.CORE_SDK_VERSION_TO_BE_PUBLISHED}}"
-      title: "Published to Registry"
-      img-url: "https://i.imgur.com/JHmKB0s.png"
-      img-alt-text: "Published to Registry"
-    secrets:
-      channel-name: ${{ secrets.SLACK_CHANNEL_ID_STORY_57BLOCKS }}
-      slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
+    runs-on: ubuntu-latest
+    environment: "odyssey"
+    steps:
+      - name: Send Slack Notification
+        run: |
+          curl -X POST \
+            -H 'Content-type: application/json' \
+            --data '{
+              "channel": "proj-sdk",
+              "text":"${{ github.repository }}: @story-protocol/core-sdk package has been published to NPM Registry, version: ${{ needs.print_version_to_publish.outputs.CORE_SDK_VERSION_TO_BE_PUBLISHED}}"
+            }' \
+            ${{ secrets.SLACK_SDK_MESSENGER_WEBHOOK_URL }}