This repository was archived by the owner on Jun 3, 2026. It is now read-only.
fix(bedrock): handle 'citation' delta key from Converse API#911
Open
rahulrsingh09 wants to merge 1 commit into
Open
fix(bedrock): handle 'citation' delta key from Converse API#911rahulrsingh09 wants to merge 1 commit into
rahulrsingh09 wants to merge 1 commit into
Conversation
Bedrock's Converse API sends citation data using the key 'citation' in both stream deltas and content blocks, but the SDK only had a handler for 'citationsContent'. This caused citations to be silently dropped with a 'skipping unsupported delta key' warning. Add 'citation' as an alias handler in both the streaming deltaHandlers and non-streaming blockHandlers to ensure citation events are properly mapped to citationsDelta events. Fixes strands-agents#910
Contributor
|
Assessment: Comment The fix correctly addresses #910 by adding Review Details
Good catch on the silent key mismatch — nice fix with end-to-end verification. |
Collaborator
|
This repository has been merged into the strands-agents/harness-sdk monorepo and will be archived shortly. All new development happens there. If this PR is still relevant, please recreate it against the monorepo. The code now lives under Apologies for the disruption, and thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bedrock's Converse API sends citation data using the key
citationin both stream deltas (contentBlockDelta) and content blocks, but the SDK only has a handler forcitationsContent. This causes citations to be silently dropped with:Solution
Add
citationas a handler in both:deltaHandlersincontentBlockDeltacase)blockHandlersin_mapStreamedBedrockEventToSDKEvent)Both handlers delegate to the same
_mapBedrockCitationsDatalogic and emitcitationsDeltaevents.Testing
handles citation delta key as alias for citationsContentcovering both streaming and non-streaming pathsFixes #910