fix: use dynamic ports from CometConfig in service builder (#500)

* fix: use dynamic ports from CometConfig in service builder

  - Change service p2p port to use crd.Spec.ChainSpec.Comet.P2PPort()
  - Change service rpc port to use crd.Spec.ChainSpec.Comet.RPCPort()
  - This fixes port mismatches when users configure custom rpcListenAddress or p2pListenAddress
  - Services now use the same dynamic port logic as container ports

* test: update service builder tests to use dynamic ports

  - Replace hardcoded 26656 with crd.Spec.ChainSpec.Comet.P2PPort()
  - Replace hardcoded 26657 with crd.Spec.ChainSpec.Comet.RPCPort()

Author: danbryan

internal/fullnode/service_builder.go

@@ -58,7 +58,7 @@ func BuildServices(crd *cosmosv1.CosmosFullNode) []diff.Resource[*corev1.Service
 			{
 				Name:       "p2p",
 				Protocol:   corev1.ProtocolTCP,
-				Port:       p2pPort,
+				Port:       crd.Spec.ChainSpec.Comet.P2PPort(),
 				TargetPort: intstr.FromString("p2p"),
 			},
 		}
@@ -148,7 +148,7 @@ func rpcService(crd *cosmosv1.CosmosFullNode) *corev1.Service {
 		{
 			Name:       "rpc",
 			Protocol:   corev1.ProtocolTCP,
-			Port:       rpcPort,
+			Port:       crd.Spec.ChainSpec.Comet.RPCPort(),
 			TargetPort: intstr.FromString("rpc"),
 		},
 		{

internal/fullnode/service_builder_test.go

@@ -51,7 +51,7 @@ func TestBuildServices(t *testing.T) {
 					{
 						Name:       "p2p",
 						Protocol:   corev1.ProtocolTCP,
-						Port:       26656,
+						Port:       crd.Spec.ChainSpec.Comet.P2PPort(),
 						TargetPort: intstr.FromString("p2p"),
 					},
 				},
@@ -92,7 +92,7 @@ func TestBuildServices(t *testing.T) {
 					{
 						Name:       "p2p",
 						Protocol:   corev1.ProtocolTCP,
-						Port:       26656,
+						Port:       crd.Spec.ChainSpec.Comet.P2PPort(),
 						TargetPort: intstr.FromString("p2p"),
 					},
 				},
@@ -192,7 +192,7 @@ func TestBuildServices(t *testing.T) {
 					{
 						Name:       "p2p",
 						Protocol:   corev1.ProtocolTCP,
-						Port:       26656,
+						Port:       crd.Spec.ChainSpec.Comet.P2PPort(),
 						TargetPort: intstr.FromString("p2p"),
 					},
 				},
@@ -310,7 +310,7 @@ func TestBuildServices(t *testing.T) {
 			{
 				Name:       "rpc",
 				Protocol:   corev1.ProtocolTCP,
-				Port:       26657,
+				Port:       crd.Spec.ChainSpec.Comet.RPCPort(),
 				TargetPort: intstr.FromString("rpc"),
 			},
 			{