Skip to content

Commit 5a9b4b4

Browse files
authored
Merge pull request #882 from strapi/release/1.6.2
2 parents 2987326 + 61a5bed commit 5a9b4b4

File tree

5 files changed

+19
-12
lines changed

5 files changed

+19
-12
lines changed

CONTRIBUTING.md

+12-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The core team will review your pull request and will either merge it, request ch
2828

2929
**Before submitting your pull request** make sure the following requirements are fulfilled:
3030

31-
- Fork the repository and create your branch from `main`.
31+
- Fork the repository and create your branch from the current `release` branch or `main` depending on if you need code in the release branch already.
3232
- Run `yarn setup` in the repository root.
3333
- If you’ve fixed a bug or added code that should be tested, add the tests and then link the corresponding issue in
3434
either your commit or your PR.
@@ -47,17 +47,17 @@ The core team will review your pull request and will either merge it, request ch
4747

4848
Please follow the instructions below:
4949

50-
#### 1. Fork the [repository](https://github.com/strapi/design-system)
50+
### 1. Fork the [repository](https://github.com/strapi/design-system)
5151

5252
[Go to the repository](https://github.com/strapi/design-system) and fork it to your own GitHub account.
5353

54-
#### 2. Clone from your repository
54+
### 2. Clone from your repository
5555

5656
```bash
5757
git clone [email protected]:YOUR_USERNAME/design-system.git
5858
```
5959

60-
#### 3. Install the dependencies and start Storybook
60+
### 3. Install the dependencies and start Storybook
6161

6262
Go to the root of the repository.
6363

@@ -69,7 +69,7 @@ yarn develop
6969

7070
Storybook will be running on `localhost:6006` for you to test your changes to components or their documentation.
7171

72-
#### 4. Start the website for documentation changes
72+
### 4. Start the website for documentation changes
7373

7474
Start the DS website to test your changes on the documentation library.
7575

@@ -79,6 +79,13 @@ yarn
7979
yarn dev
8080
```
8181

82+
### 5. Submitting a PR
83+
84+
PRs should typically be aimed at a specific release branch (there should be one made, if not make one off `main` that correlates to the milestone you're aiming for).
85+
Some circumstances will exist where this is not preferrable, e.g. updating the `workflow` files – this needs to be aimed at main to take any effect.
86+
87+
IF you submit a PR at `main` and it is merged, it is expected that you should update the existing release branches with `main`.
88+
8289
## Available commands
8390

8491
- `yarn analyze:bundle` Start webpack bundle analyzer in all packages.

docs/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@strapi/design-system-docs",
3-
"version": "1.6.1",
3+
"version": "1.6.2",
44
"license": "MIT",
55
"private": true,
66
"dependencies": {
@@ -10,8 +10,8 @@
1010
"@storybook/builder-webpack5": "^6.5.15",
1111
"@storybook/manager-webpack5": "^6.5.15",
1212
"@storybook/react": "^6.5.15",
13-
"@strapi/design-system": "^1.6.1",
14-
"@strapi/icons": "^1.6.1",
13+
"@strapi/design-system": "^1.6.2",
14+
"@strapi/icons": "^1.6.2",
1515
"qs": "^6.11.0",
1616
"react": "17",
1717
"react-copy-to-clipboard": "^5.1.0",

lerna.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"packages": ["packages/*", "docs"],
3-
"version": "1.6.1",
3+
"version": "1.6.2",
44
"npmClient": "yarn",
55
"useWorkspaces": true
66
}

packages/strapi-design-system/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@strapi/design-system",
3-
"version": "1.6.1",
3+
"version": "1.6.2",
44
"license": "MIT",
55
"type": "module",
66
"sideEffects": false,
@@ -29,7 +29,7 @@
2929
"devDependencies": {
3030
"@juggle/resize-observer": "^3.4.0",
3131
"@playwright/test": "1.27.1",
32-
"@strapi/icons": "^1.6.1",
32+
"@strapi/icons": "^1.6.2",
3333
"@swc/core": "^1.3.11",
3434
"@swc/jest": "^0.2.23",
3535
"@testing-library/jest-dom": "5.16.5",

packages/strapi-icons/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@strapi/icons",
3-
"version": "1.6.1",
3+
"version": "1.6.2",
44
"license": "MIT",
55
"type": "module",
66
"main": "./dist/index.cjs",

0 commit comments

Comments
 (0)