Skip to content

[bug]: Fails when trying to package binary imports #64

Open
@OiYouYeahYou

Description

@OiYouYeahYou

What version of @strapi/sdk-plugin are you using?

npm: 10.8.3
node: ^20
sdk: 5.2.7
browser: n/a

What's Wrong?

pack-up via sdk-plugin does not support binary imports like the one used in @ngrok/ngrok. 'sdk-pluginprovides no way to add bundlers and negates the ability to usepackup.config.jsby usingdisableConfig: falsewhen calling eitherwatchorbuild`.

To Reproduce

  1. Create a new plugin with server features
  2. Install @ngrok/ngrok which depends on an arch dependent dep with a .node binary
  3. Import this into a server file
  4. Running either watch or build will fail, as the tools only expect plaintext JS

Expected Behaviour

Allow developers to use binaries by either:

  1. Provide the ability to extend pack-up with extra bundlers
  2. Include the ability to import .node binaries by default

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue: bugIssue reporting a bugseverity: mediumIf it breaks the basic use of the product but can be worked around

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions