Pyright type issue with strawberry.file_uploads.Upload

[axiomofjoy]

Describe the Bug

VSCode and Pyright give me red squiggly lines when using strawberry.file_uploads.Upload.

Repro:

Save a file with the contents:

from strawberry.file_uploads import Upload


async def read(f: Upload) -> bytes:
    data = await f.read()
    return data

Then run pyright on this file. You will see something like

/Users/xander/memly/backend/scratch2.py
  /Users/xander/memly/backend/scratch2.py:5:5 - error: Type of "data" is unknown (reportUnknownVariableType)
  /Users/xander/memly/backend/scratch2.py:5:18 - error: Type of "read" is unknown (reportUnknownMemberType)
  /Users/xander/memly/backend/scratch2.py:5:20 - error: Cannot access member "read" for type "Upload"
    Member "read" is unknown (reportAttributeAccessIssue)
  /Users/xander/memly/backend/scratch2.py:6:12 - error: Return type is unknown (reportUnknownVariableType)
4 errors, 0 warnings, 0 informations

System Information

• Operating system: MacOS
• Strawberry version (if applicable): strawberry-graphql==0.219.2

Additional Context

[axiomofjoy]

I'm running strict mode. It looks like that's not currently supported. Any plans to support?

[furrukh-asif]

Any update here? Running into this issue in Pyright basic mode as well.

[bellini666]

This issue is happening because Upload is defined as a NewType of bytes, meaning that it indeed doesn't have those methods.

To solve that issue you can do what is described at the end of this section of the docs: https://strawberry.rocks/docs/guides/file-upload#upload-scalar . i.e. use the upload type for your framework, and define a scalar override for it.

Please let me know if that solves the issue and or if we need to change something in the documentation to make it more clear :)

[axiomofjoy]

I see, thanks. I moved off of pyright, please feel free to close the issue if it is user error.