Skip to content

Commit 5e0122a

Browse files
dependabot[bot]sfc-gh-bniscoclaude
authored
Bump ty from 0.0.61 to 0.0.62 (#72)
* Bump ty from 0.0.61 to 0.0.62 Bumps [ty](https://github.com/astral-sh/ty) from 0.0.61 to 0.0.62. - [Release notes](https://github.com/astral-sh/ty/releases) - [Changelog](https://github.com/astral-sh/ty/blob/main/CHANGELOG.md) - [Commits](astral-sh/ty@0.0.61...0.0.62) --- updated-dependencies: - dependency-name: ty dependency-version: 0.0.62 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix: satisfy ty 0.0.62 narrowing for str | None membership tests ty 0.0.62 no longer narrows `str | None` to `str` through an `x in collection` membership test, producing invalid-return-type / invalid-argument-type diagnostics in tab_nav.py and playwright_performance_runs.py. Added explicit `is not None` guards. None can never be a member of a collection of `str`, so runtime behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bob Nisco <bob.nisco@snowflake.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 835dd2f commit 5e0122a

4 files changed

Lines changed: 31 additions & 27 deletions

File tree

app/perf/playwright_performance_runs.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,11 @@ def on_query_param_change() -> None:
157157
selected_test = st.selectbox(
158158
"Select a test:",
159159
sorted_all_tests,
160-
index=(sorted_all_tests.index(selected_test) if selected_test in sorted_all_tests else 0),
160+
index=(
161+
sorted_all_tests.index(selected_test)
162+
if selected_test is not None and selected_test in sorted_all_tests
163+
else 0
164+
),
161165
on_change=on_query_param_change,
162166
key="selected_test",
163167
)

app/perf/utils/tab_nav.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def segmented_tabs(
2929
raise ValueError(msg)
3030

3131
options_list = list(options)
32-
default_value = default if default in options_list else options_list[0]
32+
default_value = default if default is not None and default in options_list else options_list[0]
3333

3434
qp_value = st.query_params.get(query_param)
3535
if isinstance(qp_value, str) and qp_value in options_list:
@@ -45,7 +45,7 @@ def segmented_tabs(
4545
)
4646

4747
# st.segmented_control may return None in some edge cases; normalize.
48-
selected = selected if selected in options_list else default_value
48+
selected = selected if selected is not None and selected in options_list else default_value
4949

5050
# Keep the URL in sync (shareable links like ?tab=Explorer).
5151
if st.query_params.get(query_param) != selected:
@@ -56,4 +56,4 @@ def segmented_tabs(
5656

5757
def ensure_one_of(value: str | None, allowed: Iterable[str], fallback: str) -> str:
5858
allowed_set = set(allowed)
59-
return value if value in allowed_set else fallback
59+
return value if value is not None and value in allowed_set else fallback

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ default-groups = ["dev"]
4848
dev = [
4949
"pytest>=9.0.2",
5050
"ruff==0.15.21",
51-
"ty==0.0.61",
51+
"ty==0.0.62",
5252
"mypy==2.3.0",
5353
"watchdog",
5454
"pandas-stubs",

uv.lock

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)