Skip to content

Commit 64ff875

Browse files
committed
E2E test fixes
1 parent 420fc1e commit 64ff875

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

.github/workflows/playwright.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,14 @@ jobs:
7676
source venv/bin/activate
7777
pip install --upgrade pip
7878
pip install -r e2e_playwright/test-requirements.txt
79+
# The venv is cached by a key that only changes daily, so a prior
80+
# run's streamlit-pivot wheel is often already installed at the
81+
# same version as the freshly-built wheel in dist/. When that
82+
# happens, pip silently skips reinstalling ("Requirement already
83+
# satisfied") and the test run exercises stale package code
84+
# instead of the current checkout. Force-reinstall the local
85+
# wheel (without deps) so the venv always reflects HEAD.
86+
pip install --force-reinstall --no-deps dist/streamlit_pivot-*.whl
7987
python -m playwright install --with-deps
8088
- name: Run playwright tests
8189
run: |

e2e_playwright/pivot_table_column_config_app.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,16 @@
2727
def render_app(data):
2828
df = data["df"]
2929

30+
# No col dims here so the single-value measure header (`pivot-header-cell`)
31+
# renders and can be inspected by the measure label/help assertions. The
32+
# col-dim + single-value layout does not surface a dedicated measure header
33+
# (values fold into the grid cells), which would render the measure-level
34+
# label/help assertions unreachable.
3035
st.subheader("column_config.label")
3136
st_pivot_table(
3237
df,
3338
key="test_pivot_cc_label",
3439
rows=["Region"],
35-
columns=["Year"],
3640
values=["Revenue"],
3741
aggregation="sum",
3842
column_config={
@@ -48,7 +52,6 @@ def render_app(data):
4852
df,
4953
key="test_pivot_cc_help",
5054
rows=["Region"],
51-
columns=["Year"],
5255
values=["Revenue"],
5356
aggregation="sum",
5457
column_config={

0 commit comments

Comments
 (0)