Remove dead code

Author: mayagbarnes

streamlit_pivot/frontend/src/PivotRoot.tsx

@@ -43,12 +43,10 @@ import {
 import { PivotData, type PivotDataOptions } from "./engine/PivotData";
 import {
   createArrowDataSource,
-  parseArrowToRecords,
   getArrowColumnNames,
   getNumericColumns,
 } from "./engine/parseArrow";
 import {
-  FEATURE_FLAGS,
   measureSync,
   logMetrics,
   checkBudgets,
@@ -134,17 +132,10 @@ const PivotRoot: FC<PivotRootProps> = ({
   );
 
   const { pivotInput, parseMs } = useMemo(() => {
-    if (FEATURE_FLAGS.arrowColumnar) {
-      const measured = measureSync(() => createArrowDataSource(dataframe));
-      const ds = measured.result;
-      return {
-        pivotInput: ds && ds.numRows > 0 ? ds : null,
-        parseMs: measured.elapsedMs,
-      };
-    }
-    const measured = measureSync(() => parseArrowToRecords(dataframe));
+    const measured = measureSync(() => createArrowDataSource(dataframe));
+    const ds = measured.result;
     return {
-      pivotInput: measured.result.length > 0 ? measured.result : null,
+      pivotInput: ds && ds.numRows > 0 ? ds : null,
       parseMs: measured.elapsedMs,
     };
   }, [dataframe]);

streamlit_pivot/frontend/src/engine/perf.ts

@@ -64,19 +64,9 @@ export interface PerfBudgets {
   maxColumnCardinality: number;
 }
 
-/** Column count above which horizontal windowing is preferred (legacy cap when wideColumnMode is off). */
+/** Column count above which horizontal windowing is preferred. */
 export const COLUMN_VIRTUALIZATION_THRESHOLD = 200;
 
-/** Hard cap when {@link FEATURE_FLAGS.wideColumnMode} is false (backward compatible). */
-export const LEGACY_MAX_COLUMN_CARDINALITY = 200;
-
-export const FEATURE_FLAGS = {
-  /** When false, column cardinality uses {@link LEGACY_MAX_COLUMN_CARDINALITY} (200). */
-  wideColumnMode: true,
-  /** Skip `DataRecord[]` materialization; feed Arrow column vectors into PivotData. */
-  arrowColumnar: true,
-};
-
 export const DEFAULT_BUDGETS: PerfBudgets = {
   maxComputeMs: 500,
   maxRenderMs: 200,

streamlit_pivot/frontend/src/shared/budgetCheck.test.ts

@@ -15,19 +15,11 @@
  * limitations under the License.
  */
 
-import { afterEach, describe, expect, it } from "vitest";
+import { describe, expect, it } from "vitest";
 import { checkRenderBudget } from "./budgetCheck";
-import {
-  DEFAULT_BUDGETS,
-  FEATURE_FLAGS,
-  LEGACY_MAX_COLUMN_CARDINALITY,
-} from "../engine/perf";
+import { DEFAULT_BUDGETS } from "../engine/perf";
 
 describe("checkRenderBudget", () => {
-  afterEach(() => {
-    FEATURE_FLAGS.wideColumnMode = true;
-  });
-
   it("returns no warnings for small pivot", () => {
     const result = checkRenderBudget(10, 5, 1);
     expect(result.needsVirtualization).toBe(false);
@@ -47,7 +39,7 @@ describe("checkRenderBudget", () => {
     expect(result.warnings.length).toBeGreaterThan(0);
   });
 
-  it("truncates columns when cardinality exceeds limit (wideColumnMode on)", () => {
+  it("truncates columns when cardinality exceeds limit", () => {
     const result = checkRenderBudget(10, 1500, 1);
     expect(result.columnsTruncated).toBe(true);
     expect(result.truncatedColumnCount).toBe(
@@ -58,23 +50,13 @@ describe("checkRenderBudget", () => {
     );
   });
 
-  it("does not truncate at 500 columns when wideColumnMode is true", () => {
+  it("does not truncate at 500 columns", () => {
     const result = checkRenderBudget(10, 500, 1);
     expect(result.columnsTruncated).toBe(false);
     expect(result.truncatedColumnCount).toBe(500);
     expect(result.needsColumnVirtualization).toBe(true);
   });
 
-  it("truncates at 200 columns when wideColumnMode is false (backward compat)", () => {
-    FEATURE_FLAGS.wideColumnMode = false;
-    const result = checkRenderBudget(10, 500, 1);
-    expect(result.columnsTruncated).toBe(true);
-    expect(result.truncatedColumnCount).toBe(LEGACY_MAX_COLUMN_CARDINALITY);
-    expect(result.warnings.some((w) => w.includes("Column cardinality"))).toBe(
-      true,
-    );
-  });
-
   it("accounts for multiple values in cell count", () => {
     const result = checkRenderBudget(100, 10, 5);
     expect(result.needsVirtualization).toBe(false);

streamlit_pivot/frontend/src/shared/budgetCheck.ts

@@ -18,8 +18,6 @@
 import {
   COLUMN_VIRTUALIZATION_THRESHOLD,
   DEFAULT_BUDGETS,
-  FEATURE_FLAGS,
-  LEGACY_MAX_COLUMN_CARDINALITY,
 } from "../engine/perf";
 
 export interface BudgetResult {
@@ -54,41 +52,6 @@ export function checkRenderBudget(
   const warnings: string[] = [];
   const needsColumnVirtualization = colCount > COLUMN_VIRTUALIZATION_THRESHOLD;
 
-  if (!FEATURE_FLAGS.wideColumnMode) {
-    let columnsTruncated = false;
-    let truncatedColumnCount = colCount;
-
-    if (colCount > LEGACY_MAX_COLUMN_CARDINALITY) {
-      columnsTruncated = true;
-      truncatedColumnCount = LEGACY_MAX_COLUMN_CARDINALITY;
-      warnings.push(
-        `Column cardinality (${colCount}) exceeds limit (${LEGACY_MAX_COLUMN_CARDINALITY}). ` +
-          `Showing first ${LEGACY_MAX_COLUMN_CARDINALITY} columns.`,
-      );
-    }
-
-    const needsVirtualization = exceedsCellBudget(
-      rowCount,
-      truncatedColumnCount,
-      valueCount,
-    );
-
-    if (needsVirtualization) {
-      warnings.push(
-        `Total cells (${(rowCount * truncatedColumnCount * Math.max(valueCount, 1)).toLocaleString()}) exceeds DOM budget ` +
-          `(${DEFAULT_BUDGETS.maxVisibleCells.toLocaleString()}). Virtualization enabled.`,
-      );
-    }
-
-    return {
-      needsVirtualization,
-      needsColumnVirtualization,
-      columnsTruncated,
-      truncatedColumnCount,
-      warnings,
-    };
-  }
-
   const maxColCap = DEFAULT_BUDGETS.maxColumnCardinality;
   const colsAfterHardCap = Math.min(colCount, maxColCap);
   const exceedsHardCap = colCount > maxColCap;