Skip to content

Commit 13832c3

Browse files
authored
fix: upgrade Go to 1.25.14 and x/sys to 0.44.0 for CVEs (#2133)
Addresses the findings Trivy reports against bin/pulsarctl in the sn-platform 4.0.12.3 image. Eight of the nine are Go stdlib (CVE-2026-33818, CVE-2026-39821, CVE-2026-46600, CVE-2026-56853, CVE-2026-56858, CVE-2026-56859, CVE-2026-56860, CVE-2026-56862) and come from the toolchain the binary is built with, so every go-version pin moves from 1.25.12 to 1.25.14 along with the go directive. The fix landed in 1.25.13; staying on the 1.25 line avoids a language version jump. The ninth is CVE-2026-39824, an integer overflow in NewNTUnicodeString, fixed by x/sys 0.39.0 -> 0.44.0. Builds clean. go vet reports one pre-existing finding in pkg/test/pulsar/standalone_test.go that is unrelated to these upgrades.
1 parent de854cb commit 13832c3

8 files changed

Lines changed: 19 additions & 19 deletions

File tree

.github/workflows/ci-bookie-checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ jobs:
1111
bookie-ut-tests:
1212
runs-on: ubuntu-latest
1313
steps:
14-
- name: Set up Go 1.25.12
14+
- name: Set up Go 1.25.14
1515
uses: actions/setup-go@v6
1616
with:
17-
go-version: 1.25.12
17+
go-version: 1.25.14
1818
id: go
1919
- name: Check out code into the Go module directory
2020
uses: actions/checkout@v2

.github/workflows/ci-functions-checks.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ jobs:
1414
- name: Login SN docker hub
1515
if: github.actor == 'streamnativebot'
1616
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
17-
- name: Set up Go 1.25.12
17+
- name: Set up Go 1.25.14
1818
uses: actions/setup-go@v6
1919
with:
20-
go-version: 1.25.12
20+
go-version: 1.25.14
2121
id: go
2222
- name: Check out code into the Go module directory
2323
uses: actions/checkout@v2
@@ -34,10 +34,10 @@ jobs:
3434
- name: Login SN docker hub
3535
if: github.actor == 'streamnativebot'
3636
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
37-
- name: Set up Go 1.25.12
37+
- name: Set up Go 1.25.14
3838
uses: actions/setup-go@v6
3939
with:
40-
go-version: 1.25.12
40+
go-version: 1.25.14
4141
id: go
4242
- name: Check out code into the Go module directory
4343
uses: actions/checkout@v2
@@ -51,10 +51,10 @@ jobs:
5151
- name: Login SN docker hub
5252
if: github.actor == 'streamnativebot'
5353
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
54-
- name: Set up Go 1.25.12
54+
- name: Set up Go 1.25.14
5555
uses: actions/setup-go@v6
5656
with:
57-
go-version: 1.25.12
57+
go-version: 1.25.14
5858
id: go
5959
- name: Check out code into the Go module directory
6060
uses: actions/checkout@v2

.github/workflows/ci-packages-checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ jobs:
1414
- name: Login SN docker hub
1515
if: github.actor == 'streamnativebot'
1616
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
17-
- name: Set up Go 1.25.12
17+
- name: Set up Go 1.25.14
1818
uses: actions/setup-go@v5
1919
with:
20-
go-version: 1.25.12
20+
go-version: 1.25.14
2121
id: go
2222
- name: Check out code into the Go module directory
2323
uses: actions/checkout@v2

.github/workflows/ci-release-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: ubuntu-latest
1515
strategy:
1616
matrix:
17-
go-version: [ 1.25.12 ]
17+
go-version: [ 1.25.14 ]
1818
steps:
1919
- uses: actions/checkout@v2
2020
- uses: actions/setup-go@v5

.github/workflows/ci-style-checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ jobs:
1111
style-check:
1212
runs-on: ubuntu-latest
1313
steps:
14-
- name: Set up Go 1.25.12
14+
- name: Set up Go 1.25.14
1515
uses: actions/setup-go@v5
1616
with:
17-
go-version: 1.25.12
17+
go-version: 1.25.14
1818
id: go
1919
- name: Check out code into the Go module directory
2020
uses: actions/checkout@v2

.github/workflows/ci-trivy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
scan-vulnerabilities:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- name: Set up Go 1.25.12
15+
- name: Set up Go 1.25.14
1616
uses: actions/setup-go@v5
1717
with:
18-
go-version: 1.25.12
18+
go-version: 1.25.14
1919
id: go
2020

2121
- name: Check out code into the Go module directory

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/streamnative/pulsarctl
22

3-
go 1.25.12
3+
go 1.25.14
44

55
require (
66
github.com/apache/pulsar-client-go v0.18.0-candidate-1.0.20251222030102-3bb7d4eff361
@@ -93,7 +93,7 @@ require (
9393
golang.org/x/mod v0.31.0 // indirect
9494
golang.org/x/net v0.48.0 // indirect
9595
golang.org/x/oauth2 v0.34.0 // indirect
96-
golang.org/x/sys v0.39.0 // indirect
96+
golang.org/x/sys v0.44.0 // indirect
9797
golang.org/x/text v0.32.0 // indirect
9898
google.golang.org/genproto/googleapis/api v0.0.0-20251222181119-0a764e51fe1b // indirect
9999
google.golang.org/genproto/googleapis/rpc v0.0.0-20251222181119-0a764e51fe1b // indirect

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBc
285285
golang.org/x/sys v0.8.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
286286
golang.org/x/sys v0.11.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
287287
golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
288-
golang.org/x/sys v0.39.0 h1:CvCKL8MeisomCi6qNZ+wbb0DN9E5AATixKsvNtMoMFk=
289-
golang.org/x/sys v0.39.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
288+
golang.org/x/sys v0.44.0 h1:ildZl3J4uzeKP07r2F++Op7E9B29JRUy+a27EibtBTQ=
289+
golang.org/x/sys v0.44.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
290290
golang.org/x/term v0.38.0 h1:PQ5pkm/rLO6HnxFR7N2lJHOZX6Kez5Y1gDSJla6jo7Q=
291291
golang.org/x/term v0.38.0/go.mod h1:bSEAKrOT1W+VSu9TSCMtoGEOUcKxOKgl3LE5QEF/xVg=
292292
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

0 commit comments

Comments
 (0)